Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-1712] Pin ubuntu version in workflows #545

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

baxelrod-bdai
Copy link
Collaborator

Change Overview

This is simply a find/replace of ubuntu-latest -> ubuntu-22.04. Because ubuntu-latest will become 24.04 soon. We should pin to 22.04 which matches our development environment.

Testing Done

None. This PR is the test. (Assuming this repo has CI)

@coveralls
Copy link

coveralls commented Jan 7, 2025

Pull Request Test Coverage Report for Build 12678020084

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.866%

Totals Coverage Status
Change from base Build 12659286764: 0.0%
Covered Lines: 2126
Relevant Lines: 4099

💛 - Coveralls

Copy link
Collaborator

@khughes-bdai khughes-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baxelrod-bdai baxelrod-bdai force-pushed the baxelrod/SW-1712-pin-ubuntu-version-in-ci branch from 322f8ae to 5e3dc73 Compare January 8, 2025 19:37
@baxelrod-bdai baxelrod-bdai force-pushed the baxelrod/SW-1712-pin-ubuntu-version-in-ci branch from 5e3dc73 to 956077c Compare January 8, 2025 19:55
Copy link
Collaborator Author

baxelrod-bdai commented Jan 8, 2025

Merge activity

  • Jan 8, 2:56 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 8, 3:11 PM EST: A user merged this pull request with Graphite.

@baxelrod-bdai baxelrod-bdai merged commit 1a1e721 into main Jan 8, 2025
4 checks passed
@baxelrod-bdai baxelrod-bdai deleted the baxelrod/SW-1712-pin-ubuntu-version-in-ci branch January 8, 2025 20:11
khughes-bdai pushed a commit that referenced this pull request Jan 14, 2025
## Change Overview

This is simply a find/replace of `ubuntu-latest` -> `ubuntu-22.04`.  Because `ubuntu-latest` will become 24.04 soon.  We should pin to 22.04 which matches our development environment.

## Testing Done

None. This PR is the test.  (Assuming this repo has CI)

Signed-off-by: Katie Hughes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants