Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Coveralls path #290

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Fix Coveralls path #290

merged 2 commits into from
Mar 1, 2024

Conversation

mhidalgo-bdai
Copy link
Collaborator

Change Overview

Follow-up to #256. It broke source paths in coverage reports.

This patch amends the situation.

Testing Done

  • Test Coveralls report can locate sources in repository

Sorry, something went wrong.

Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
@mhidalgo-bdai mhidalgo-bdai self-assigned this Mar 1, 2024
@mhidalgo-bdai mhidalgo-bdai requested a review from jiuguangw as a code owner March 1, 2024 14:29
@mhidalgo-bdai mhidalgo-bdai added the bug Something isn't working label Mar 1, 2024
@mhidalgo-bdai
Copy link
Collaborator Author

GHA is on a partial outage. That's why jobs never finish.

Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
@mhidalgo-bdai
Copy link
Collaborator Author

Well, setting base paths is not enough and coveralls docs are very limited. I'll just restore the layout we had before the rework. Despite leaving the runner workspace, that worked.

Copy link

Pull Request Test Coverage Report for Build 8114386132

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.018%

Totals Coverage Status
Change from base Build 8102505743: 0.0%
Covered Lines: 2125
Relevant Lines: 4758

💛 - Coveralls

@amessing-bdai amessing-bdai merged commit 68cf947 into main Mar 1, 2024
8 checks passed
@amessing-bdai amessing-bdai deleted the mhidalgo-bdai/fix-coveralls-paths branch March 1, 2024 18:15
marlow-fawn pushed a commit to marlow-fawn/spot_ros2 that referenced this pull request Aug 19, 2024
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants