Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SW-1836] Move values.py from bdai_ros to synchros2 #138

Merged
merged 2 commits into from
Jan 16, 2025
Merged

[SW-1836] Move values.py from bdai_ros to synchros2 #138

merged 2 commits into from
Jan 16, 2025

Conversation

tcappellari-bdai
Copy link
Collaborator

Proposed changes

Moved values.py from bdai_ros.launch to synchros2.launch

Checklist

  • Lint and unit tests pass locally
  • I have added tests that prove my changes are effective
  • I have added necessary documentation to communicate the changes

Additional comments

@tcappellari-bdai tcappellari-bdai merged commit 5bff590 into main Jan 16, 2025
5 checks passed
@tcappellari-bdai tcappellari-bdai deleted the SW-1836-move-launch-configuration-values-out-of-bdai-ros-into-synchros-2 branch January 16, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjin-bdai bjin-bdai bjin-bdai approved these changes

@jcarpinelli-bdai jcarpinelli-bdai jcarpinelli-bdai approved these changes

@mbrauckmann-bdai mbrauckmann-bdai Awaiting requested review from mbrauckmann-bdai mbrauckmann-bdai was automatically assigned from bdaiinstitute/rapid

@khughes-bdai khughes-bdai Awaiting requested review from khughes-bdai khughes-bdai was automatically assigned from bdaiinstitute/rapid

@mgoh-bdai mgoh-bdai Awaiting requested review from mgoh-bdai mgoh-bdai was automatically assigned from bdaiinstitute/rapid

@mvictora-bdai mvictora-bdai Awaiting requested review from mvictora-bdai mvictora-bdai was automatically assigned from bdaiinstitute/rapid

@jbarry-bdai jbarry-bdai Awaiting requested review from jbarry-bdai jbarry-bdai is a code owner

@amessing-bdai amessing-bdai Awaiting requested review from amessing-bdai amessing-bdai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcappellari-bdai @jcarpinelli-bdai @bjin-bdai