[SW-1667] Install custom launch actions properly #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcappellari-bdai
changed the title
tcappellari-bdai
requested review from
jbarry-bdai and
amessing-bdai
as code owners
tcappellari-bdai
force-pushed
the
SW-1667-move-launch-actions-to-install
branch
from
38382d0 to
5a237cc
Compare
|
Question since my setup.py skills are not great -- in light of the renaming, should this be happening in synchos2 setup.py or bdai_ros2_wrappers or both? |
|
synchros2 is already like this but bdai_ros2_wrappers was not. The two are now identical (more or less) in the setup.py |
There was a problem hiding this comment.
@tcappellari-bdai I think this isn't necessary anymore. synchros2 already installs synchros2.launch and bdai_ros2_wrappers is just a trampoline to it.
| data_files=[ | ||
| ("share/ament_index/resource_index/packages", ["resource/" + package_name]), | ||
| ("share/" + package_name, ["package.xml"]), | ||
| ], | ||
| install_requires=["setuptools"], | ||
| maintainer="The AI Institute", | ||
| maintainer_email="[email protected]", | ||
| description="The AI Institute's wrappers for ROS2", | ||
| maintainer_email="[email protected]", |
There was a problem hiding this comment.
@tcappellari-bdai ahh, I missed this on synchros2 too!
|
closing since this package is going to be deleted at some point (replaced with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the setup.py so the custom launch actions get installed in the /install directory properly so we can use them in other packages.
Also updated the maintainer email