Allow proto2ros_generate() to depend on protobuf_generate()
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <[email protected]>
mhidalgo-bdai
requested review from
tervay-bdai,
tperkins-bdai and
khughes-bdai
mhidalgo-bdai
requested review from
jbarry-bdai and
amessing-bdai
as code owners
mhidalgo-bdai
commented
Oct 7, 2024
| @@ -45,9 +45,7 @@ proto2ros_generate( | |||
| CPP_OUT_VAR cpp_sources | |||
| INCLUDE_OUT_VAR cpp_include_dir | |||
| APPEND_PYTHONPATH "${PROTO_OUT_DIR}" | |||
| ) | |||
| add_dependencies( | |||
| ${PROJECT_NAME}_messages_gen ${PROJECT_NAME}_proto_gen | |||
There was a problem hiding this comment.
This adds the dependency to the custom target that is downstream of the actual proto2ros generate command, so it doesn't really work.
khughes-bdai
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precisely what the title says. Also fixes a race in
proto2ros_testsas a result of failing to establish this dependency.