Allow adapted feeds to filter messages #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <[email protected]>
mhidalgo-bdai
requested review from
jbarry-bdai and
amessing-bdai
as code owners
mhidalgo-bdai
commented
Oct 2, 2024
| TypeVar, | ||
| Union, | ||
| overload, | ||
| ) |
There was a problem hiding this comment.
black decided it was time to reformat 🤷♂️
There was a problem hiding this comment.
There is a line length limit for black.
mhidalgo-bdai
commented
Oct 2, 2024
| """ | ||
| super().__init__() | ||
| self.fn = fn | ||
| self.connection = upstream.registerCallback(self.add) | ||
|
|
||
| def add(self, *messages: Any) -> None: | ||
| """Adds new `messages` to the adapter.""" | ||
| self.signalMessage(self.fn(*messages)) | ||
| result = self.fn(*messages) |
There was a problem hiding this comment.
@amessing-bdai ended up going with the trivial implementation. There is a way, an async way, for fn to nicely embed complex, stateful logic in a functional way, but it was more trouble than it was worth. If one needs lots of bookkeeping and control flow for an adapter, it may be about time to write a new filter.
amessing-bdai
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a simple, generic mechanism for
AdaptedFeedinstances to drop messages.