Address peer review comments

Signed-off-by: Michel Hidalgo <[email protected]>
bdaiinstitute · Nov 25, 2024 · a581ebe · a581ebe
1 parent a76b9fa
commit a581ebe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/bdai_ros2_wrappers/bdai_ros2_wrappers/feeds.py b/bdai_ros2_wrappers/bdai_ros2_wrappers/feeds.py
@@ -197,6 +197,7 @@ def __init__(
         self,
         feed: MessageFeed,
         fn: Callable[..., MessageT],
+        *,
         autostart: bool = True,
         **kwargs: Any,
     ) -> None:

diff --git a/bdai_ros2_wrappers/bdai_ros2_wrappers/filters.py b/bdai_ros2_wrappers/bdai_ros2_wrappers/filters.py
@@ -220,6 +220,7 @@ def __init__(
         target_frame_id: str,
         tf_buffer: tf2_ros.Buffer,
         tolerance_sec: float,
+        *,
         logger: Optional[RcutilsLogger] = None,
         autostart: bool = True,
     ) -> None:
@@ -331,7 +332,7 @@ def add(self, *messages: Any) -> None:
 class Adapter(Filter):
     """A message filter for data adaptation."""
 
-    def __init__(self, upstream: Filter, fn: Callable, autostart: bool = True) -> None:
+    def __init__(self, upstream: Filter, fn: Callable, *, autostart: bool = True) -> None:
         """Initializes the adapter.
 
         Args:
@@ -369,7 +370,7 @@ def add(self, *messages: Any) -> None:
 class Tunnel(Filter):
     """A message filter that simply forwards messages but can be detached."""
 
-    def __init__(self, upstream: Filter, autostart: bool = True) -> None:
+    def __init__(self, upstream: Filter, *, autostart: bool = True) -> None:
         """Initializes the tunnel.
 
         Args: