Skip to content

Commit

Permalink
Address peer review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Michel Hidalgo <[email protected]>
  • Loading branch information
mhidalgo-bdai committed Mar 26, 2024
1 parent a78aefe commit 3159cdc
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions bdai_ros2_wrappers/bdai_ros2_wrappers/executors.py
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,6 @@ def __init__(
) -> None:
self.task = task
self.entity = entity
self.valid = lambda: True
if node is not None and hasattr(node, "destruction_requested"):
self.valid = lambda: not node.destruction_requested # type: ignore
else:
Expand Down Expand Up @@ -679,8 +678,7 @@ def shutdown(self, timeout_sec: typing.Optional[float] = None) -> bool:
# rclpy.executors.Executor base implementation leaves tasks
# unawaited upon shutdown. Do the housekeepng.
for task, entity, node in self._tasks:
Task = AutoScalingMultiThreadedExecutor.Task
task = Task(task, entity, node)
task = AutoScalingMultiThreadedExecutor.Task(task, entity, node)
task.cancel()
return done

Expand Down

0 comments on commit 3159cdc

Please sign in to comment.