Restore some comments and add new tests of the function is_number.

bcoconni · Feb 9, 2025 · bd6be49 · bd6be49
1 parent 7c647c6
commit bd6be49
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/src/input_output/string_utilities.cpp b/src/input_output/string_utilities.cpp
@@ -93,6 +93,7 @@ double atof_locale_c(const string& input)
     first++;
   }
 
+  // Skip leading whitespaces
   if (!*first) {
     InvalidNumber e("Expecting a numeric attribute value, but only got spaces");
     cerr << e.what() << endl;

diff --git a/src/models/flight_control/FGSwitch.cpp b/src/models/flight_control/FGSwitch.cpp
@@ -91,9 +91,9 @@ FGSwitch::FGSwitch(FGFCS* fcs, Element* element) : FGFCSComponent(fcs, element)
       current_test->setTestValue(value, Name, PropertyManager, test_element);
       current_test->Default = true;
       auto output_value = current_test->OutputValue.ptr();
-      if (delay > 0 && dynamic_cast<FGRealValue*>(output_value)) {
+      if (delay > 0 && dynamic_cast<FGRealValue*>(output_value)) { // If there is a delay
         double v = output_value->GetValue();
-        for (unsigned int i=0; i<delay-1; i++) {  // delay buffer to the default value
+        for (unsigned int i=0; i<delay-1; i++) {  // Initialize the delay buffer to the default value
           output_array[i] = v;                    // for the switch if that value is a number.
         }
       }

diff --git a/tests/unit_tests/StringUtilitiesTest.h b/tests/unit_tests/StringUtilitiesTest.h
@@ -50,6 +50,19 @@ class StringUtilitiesTest : public CxxTest::TestSuite
     TS_ASSERT(is_number("-1.0e+1"));
     TS_ASSERT(!is_number(empty));
     TS_ASSERT(!is_number("125x5#"));
+    TS_ASSERT(!is_number("x"));
+    TS_ASSERT(!is_number("1.0.0"));
+    TS_ASSERT(!is_number("1.0e"));
+    TS_ASSERT(!is_number("1.0e+"));
+    TS_ASSERT(!is_number("1.0e1.0"));
+    TS_ASSERT(!is_number("--1"));
+    TS_ASSERT(!is_number("++1"));
+    TS_ASSERT(!is_number("1+"));
+    TS_ASSERT(!is_number("1-"));
+    TS_ASSERT(!is_number(""));
+    TS_ASSERT(!is_number(" "));
+    TS_ASSERT(!is_number("3.14a"));
+    TS_ASSERT(!is_number("-.1e-"));
   }
 
   void testSplit() {