Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS tidy #8

Merged
merged 1 commit into from
Nov 20, 2023
Merged

CSS tidy #8

merged 1 commit into from
Nov 20, 2023

Conversation

TimCsaky
Copy link
Contributor

Description

ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3384
In trying to resolve a css conflict (presenting since primevue's adoption of css @layers - after version 3.34.1), this PR does the following:

  • consolidate css
  • use primeflex helpers where possible
  • make header/main/footer layout adapt better to smaller screens
  • remove margin/padding reset on *
  • change Dockerfile app build command

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

@TimCsaky TimCsaky force-pushed the css branch 5 times, most recently from cbded53 to ad43691 Compare November 15, 2023 21:59
Copy link

github-actions bot commented Nov 15, 2023

Coverage Report (Frontend)

Totals Coverage
Statements: 50.6% ( 169 / 334 )
Methods: 50% ( 37 / 74 )
Lines: 55.67% ( 108 / 194 )
Branches: 36.36% ( 24 / 66 )

@kyle1morel kyle1morel merged commit 8207936 into master Nov 20, 2023
17 checks passed
@kyle1morel kyle1morel deleted the css branch November 20, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants