Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor backend stack to explicitly transpile code #11

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

jujaga
Copy link
Member

@jujaga jujaga commented Dec 20, 2023

Description

In order to improve performance and avoid typescript issues during runtime, we are compiling first instead of transpiling on the fly.

SHOWCASE-3446

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

In order to improve performance and avoid typescript issues during runtime,
we are compiling first instead of transpiling on the fly.

Signed-off-by: Jeremy Ho <[email protected]>
@jujaga jujaga added the bug Something isn't working label Dec 20, 2023
@jujaga jujaga self-assigned this Dec 20, 2023
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 50.6% ( 169 / 334 )
Methods: 50% ( 37 / 74 )
Lines: 55.67% ( 108 / 194 )
Branches: 36.36% ( 24 / 66 )

@wilwong89 wilwong89 merged commit e014afa into master Dec 20, 2023
18 of 19 checks passed
@wilwong89 wilwong89 deleted the ci/tsc branch December 20, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants