Skip to content

Commit

Permalink
Clean up docker.release file
Browse files Browse the repository at this point in the history
Add guiding comments
  • Loading branch information
BronzBierd committed Jan 21, 2025
1 parent 348b9dd commit e052528
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions docker/web/Dockerfile.release
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,17 @@ ARG NODE_VERSION
ARG WEB_SRC
ARG NPM_INSTALL_ARGS

# npm install fails with EACCES: permission denied when running as root user for a scss package used in Vue 2.
# The workaround is to run the build as a non-root user and set the permissions on the files copied to the image.
# This should be revisited when the application is upgraded to Vue 3. See bcgov/jasper repo for guidance on Vue 3 ready image.
# USER root
WORKDIR /opt/app-root/src

# Copy package.json and package-lock.json
COPY --chmod=674 ${WEB_SRC}/package*.json .

# NPM INSTALL fails as root, this is due to a legacy SCSS package, this is not required in VUE3 (REMOVE WHEN UPGRADING)
# USER 104
# Install packages
RUN npm install ${NPM_INSTALL_ARGS}
# NPM INSTALL fails as root, this is due to a legacy SCSS package, this is not required in VUE3 (REMOVE WHEN UPGRADING)
# USER root

# Copy the source code
COPY --chmod=674 ${WEB_SRC} .
Expand Down

0 comments on commit e052528

Please sign in to comment.