Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: benchmark tests email results report #425

Merged
merged 9 commits into from
Jan 27, 2025
Merged

Conversation

NithinKuruba
Copy link
Contributor

No description provided.

Copy link
Contributor

@thegentlemanphysicist thegentlemanphysicist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add some explicit documentation on deploying the benchmark keycloak docker image? (or something like a link to the documentation like referencing 'build and new testing image and deploy from local using values file ###)


#### Pre-requisites

- Java 21 if running locally
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the java version installed to build the benchmark test runner that will be deployed in openshift? If so is it included in the keycloak repo's asdf tool version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need Java 21 only if you are running the tests locally in your machine but when running in the Openshift, the docker image has the Java Runtime pre-installed

@NithinKuruba
Copy link
Contributor Author

Is it possible to add some explicit documentation on deploying the benchmark keycloak docker image? (or something like a link to the documentation like referencing 'build and new testing image and deploy from local using values file ###)

Updated documentation with steps to build the images

@NithinKuruba NithinKuruba merged commit 1deeae7 into dev Jan 27, 2025
6 checks passed
@NithinKuruba NithinKuruba deleted the SSOTEAM-2187-01 branch January 27, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants