This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
chore: Bb 300 create blueberries calculation table json file #328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a new calculation table for Blueberries based on the Raspberries calculation table.
I kept the structure as much as possible to avoid too much adaptation on the current calculation functions.
This means that for one of the nutrient requirements, one of the ranges is not truly being used, but being kept there for compatibility. Otherwise I'd need to update the calculation table interface and perhaps deal with some refactoring.
This should work and it doesn't look bad, it actually keeps the tables uniform and should work quite easily on the calculation implementation. We'll see.
The calculation function later on will need to check for and use two new attributes, plants per acre and plant age. This shouldn't be too hard. Famous last words 😄
Check out this commit to see what changes were required. Blueberry calculations actually check for less ranges then raspberries, which results in removing more data then adding.
Type of changes
Please delete options that are not relevant.
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: