Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

chore: Bb 300 create blueberries calculation table json file #328

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

GDamaso
Copy link
Contributor

@GDamaso GDamaso commented Aug 5, 2024

Description

Created a new calculation table for Blueberries based on the Raspberries calculation table.

I kept the structure as much as possible to avoid too much adaptation on the current calculation functions.
This means that for one of the nutrient requirements, one of the ranges is not truly being used, but being kept there for compatibility. Otherwise I'd need to update the calculation table interface and perhaps deal with some refactoring.

This should work and it doesn't look bad, it actually keeps the tables uniform and should work quite easily on the calculation implementation. We'll see.

The calculation function later on will need to check for and use two new attributes, plants per acre and plant age. This shouldn't be too hard. Famous last words 😄

Check out this commit to see what changes were required. Blueberry calculations actually check for less ranges then raspberries, which results in removing more data then adding.

Type of changes

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

GDamaso added 3 commits August 5, 2024 11:53
Am commiting early so we can see what changes are necessary between Raspberry and Blueberry
Calculation tables
@GDamaso GDamaso linked an issue Aug 5, 2024 that may be closed by this pull request
1 task
Copy link
Contributor Author

@GDamaso GDamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@GDamaso GDamaso merged commit f88c712 into main Aug 5, 2024
21 checks passed
@GDamaso GDamaso deleted the BB-300-create-blueberries-calculation-table-json-file branch August 5, 2024 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Blueberries Calculation Table (JSON file)
2 participants