Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

chore: Bb 317 update loading nmp files in bb #319

Merged
merged 15 commits into from
Aug 3, 2024

Conversation

GDamaso
Copy link
Contributor

@GDamaso GDamaso commented Aug 1, 2024

Description

BB now loads virtually any fert from a field with it's label onto the calculate nutrients list for the given field.

Please help me test and catch any major bug from this ticket. You can ask me for an .nmp file I created with all the fert options. I used it for mapping the ferts ids and testing.

Type of changes

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

NMP Ferts

image

BB loading NMP Ferts

image


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@GDamaso GDamaso linked an issue Aug 1, 2024 that may be closed by this pull request
1 task
Copy link
Contributor Author

@GDamaso GDamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Contributor Author

@GDamaso GDamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌
Couldn't find any major bug, good enough for now

kcaparas1630

This comment was marked as resolved.

Copy link
Contributor

@kcaparas1630 kcaparas1630 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was loading the nmp file that you've sent me. I've noticed that it's starting on Crop ID 2
image
image

I'm not sure if it's the Openshift Link's not recently updated but here's what the fertilizer name looks in my end.
image

Again, this might be Openshift or a file problem. Creating a new calculation looks great.
Only thing I would like to mention is that, whenever you're returning back to calculation, fertilizer details are not being saved to the local storage, thus returning as empty object array and not the fertilizers that I've added.

@kcaparas1630
Copy link
Contributor

tried reloading it and resetting my cache
here's what's happening on my end. it's returning the number value of that option.
image

@GDamaso
Copy link
Contributor Author

GDamaso commented Aug 3, 2024

Openshift is not updating the deployment, you gotta pull the branch and test it locally. Those bugs should have been fixed already:

Crop id's

image

Fert names after page refresh and returning to calc from export page

image

The id's being subbed by 0 got fixed on a commit I just pushed.

Try it ou locally on desktop and let me know 😄

@kcaparas1630
Copy link
Contributor

Tested it out and it works well. One thing I would like to ask is that, since we have fertilizers printed on the list. Shouldn't it appear here in the Fertilizer CustomSelect Component as well? There's a lot of dry fertilizers but it doesn't let me choose another fertilizer to add to the field, or add that fertilizer in another field.
image

@GDamaso
Copy link
Contributor Author

GDamaso commented Aug 3, 2024

I totally agree with that new feature. Will create a new ticket for it. For now, we should move onto the blueberry calculation.

@GDamaso GDamaso merged commit 96f0164 into main Aug 3, 2024
30 of 32 checks passed
@GDamaso GDamaso deleted the BB-317-update-loading-nmp-files-in-bb branch August 3, 2024 07:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Loading nmp files in BB
2 participants