-
Notifications
You must be signed in to change notification settings - Fork 2
chore: Bb 317 update loading nmp files in bb #319
Conversation
It was removed for the transition animation but it render the bool array before fields was populated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
This should be done using the backend, but will sufice for now Its modular enough that it should be easy to just fetch this data when moving it to the db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Couldn't find any major bug, good enough for now
frontend/src/Commons/Forms/InputModules/CalculateNutrients/CalculateNutrients.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I was loading the nmp file that you've sent me. I've noticed that it's starting on Crop ID 2
I'm not sure if it's the Openshift Link's not recently updated but here's what the fertilizer name looks in my end.
Again, this might be Openshift or a file problem. Creating a new calculation looks great.
Only thing I would like to mention is that, whenever you're returning back to calculation, fertilizer details are not being saved to the local storage, thus returning as empty object array and not the fertilizers that I've added.
Openshift is not updating the deployment, you gotta pull the branch and test it locally. Those bugs should have been fixed already: Crop id'sFert names after page refresh and returning to calc from export pageThe id's being subbed by 0 got fixed on a commit I just pushed. Try it ou locally on desktop and let me know 😄 |
I totally agree with that new feature. Will create a new ticket for it. For now, we should move onto the blueberry calculation. |
Description
BB now loads virtually any fert from a field with it's label onto the calculate nutrients list for the given field.
Please help me test and catch any major bug from this ticket. You can ask me for an .nmp file I created with all the fert options. I used it for mapping the ferts ids and testing.
Type of changes
Please delete options that are not relevant.
Checklist
Further comments
NMP Ferts
BB loading NMP Ferts
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: