Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added document type to the document list #372

Merged
merged 6 commits into from
Feb 1, 2025
Merged

feat: Added document type to the document list #372

merged 6 commits into from
Feb 1, 2025

Conversation

popkinj
Copy link
Contributor

@popkinj popkinj commented Jan 31, 2025

  • Document extension/type added to the documents list.
  • Defaults to (DOC)
    Screenshot from 2025-01-31 10-24-35

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@popkinj
Copy link
Contributor Author

popkinj commented Jan 31, 2025

Screenshot from 2025-01-31 10-33-07

@kdbelair
Copy link

After some testing, its not picking up the .docx format well. Some samples include auths #110536, 108529, 108541, 12398, 108982

documentformat

@popkinj
Copy link
Contributor Author

popkinj commented Jan 31, 2025

Ah yes... There were file names with multiple periods. Try it now @kdbelair .

@kdbelair
Copy link

kdbelair commented Feb 1, 2025

It looks some of the .docx files are showing as (DOC). Others are being correctly reported as (DOCX). Would that be an easy fix?

@popkinj popkinj merged commit 6a5cb74 into main Feb 1, 2025
20 checks passed
@popkinj popkinj deleted the auth-236 branch February 1, 2025 20:30
@popkinj
Copy link
Contributor Author

popkinj commented Feb 1, 2025

Ah yes... There were file names with multiple periods. Try it now @kdbelair .

It looks some of the .docx files are showing as (DOC). Others are being correctly reported as (DOCX). Would that be an easy fix?

Maybe yes or maybe no. The default file type is (.DOC). So if the filename doesn't have an extension or it is improperly named that's what it gets. Do you have an example I can use?

@kdbelair
Copy link

kdbelair commented Feb 3, 2025

@popkinj Some example of auths that have docx files show up as DOC on the page: 108529, 12398, 108982

@popkinj
Copy link
Contributor Author

popkinj commented Feb 3, 2025

Ah yes. I see the issue now thanks to your examples @kdbelair
So the limitation is with the data we're getting. The AMS is telling use the "file name" doesn't have a docx extension... Yet when we download it, it's there. If I'm not mistaken, this is the limitation we chatted about earlier.
Screenshot from 2025-02-03 13-43-22

@kdbelair
Copy link

kdbelair commented Feb 4, 2025

Thanks @popkinj, as discussed we will show "(DOC/DOCX)" in this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants