Skip to content

Commit

Permalink
feat(ci): improve results job (#96)
Browse files Browse the repository at this point in the history
* feat(ci): add smarter results job

* Roll results and PR description decorator together

* Work on outputting BUILD_OBJECT

* Work on outputting BUILD_OBJECT

* Simplify and rename last job PR Results

* Rename job
  • Loading branch information
DerekRoberts authored May 27, 2024
1 parent 5d1d2af commit 7e3f9e0
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions .github/workflows/pr-open.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ concurrency:
cancel-in-progress: true

jobs:
scrub:
name: Scrub for changed Dockerfiles
checks:
name: Dockerfile Checks
runs-on: ubuntu-22.04
outputs:
json: ${{ steps.dockerfiles.outputs.json }}
Expand Down Expand Up @@ -45,14 +45,14 @@ jobs:
# https://github.com/bcgov-nr/action-builder-ghcr
builds:
name: Builds
needs: [scrub]
if: ${{ needs.scrub.outputs.json }}
needs: [checks]
if: ${{ needs.checks.outputs.json }}
permissions:
packages: write
runs-on: ubuntu-22.04
strategy:
matrix:
include: ${{ fromJSON(needs.scrub.outputs.json) }}
include: ${{ fromJSON(needs.checks.outputs.json) }}
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
Expand All @@ -69,10 +69,10 @@ jobs:
package: ${{ matrix.package }}
tag: ${{ steps.tag.outputs.full_tag }}

pr-description-add:
name: PR Description Add
needs: [builds]
if: always() && (! failure())
results:
name: PR Results
needs: [checks, builds]
if: always() && (!failure()) && (!cancelled())
runs-on: ubuntu-22.04
permissions:
pull-requests: write
Expand All @@ -84,6 +84,6 @@ jobs:
add_markdown: |
---
Thanks for the PR!
Thanks for the PR! Our PR workflow has completed successfully. :)
Any new images should be viewable with [our repo packages](https://github.com/orgs/bcgov/packages?repo_name=nr-containers). :)
Any new images should be viewable with [our repo packages](https://github.com/orgs/bcgov/packages?repo_name=nr-containers).

0 comments on commit 7e3f9e0

Please sign in to comment.