Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto selfassign on quick close and validate during status update #912

Open
wants to merge 6 commits into
base: release/1.0.2
Choose a base branch
from

Conversation

jon-funk
Copy link
Collaborator

@jon-funk jon-funk commented Jan 29, 2025

Description

Implements CE-1350

  • An officer must be assigned to the overall complaint before changing the status of the complaint (both to close, and reopen a complaint)
  • During a quick close, if no officer is assigned, then the current user will be assigned

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested on both open/closed complaints
  • Tested on complaints with/without officers already assigned

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@jon-funk jon-funk added the not ready Not ready for review, WIP, do not merge. label Jan 29, 2025
@jon-funk jon-funk removed the not ready Not ready for review, WIP, do not merge. label Jan 31, 2025
Copy link
Contributor

@mikevespi mikevespi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good! The self assign isn't working for me with the quickclose modal though, is it working for you locally?

@@ -114,6 +115,19 @@ export const ChangeStatusModal: FC<ChangeStatusModalProps> = ({ close, submit, c
</Col>
</Row>
)}
{!is_officer_assigned && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add check that the selectedStatus is closed? As it is, the warning text comes up even if closed isn't selected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants