Feature/deseng666 Add new Engagement Details page #2574
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2574 +/- ##
=======================================
Coverage 76.03% 76.03%
=======================================
Files 609 609
Lines 22075 22076 +1
Branches 1782 1783 +1
=======================================
+ Hits 16785 16786 +1
Misses 5026 5026
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| return data.engagement.then((engagement) => { | ||
| return { | ||
| link: `/engagements/${engagement.id}/view`, | ||
| name: engagement.name, |
There was a problem hiding this comment.
Nicely done with the breadcrumb function :)
| <Breadcrumbs aria-label="breadcrumb" sx={smallScreenOnly ? { display: { xs: 'block', md: 'none' } } : {}}> | ||
| <Breadcrumbs | ||
| aria-label="breadcrumb" | ||
| component="nav" |
There was a problem hiding this comment.
thanks for making this a11y improvement :3
There was a problem hiding this comment.
Sorry, I just realized - all the components in components/engagement/old-view are unused and have no references to them, so they are redundant. All the components are still present in components/engagement/view since they were copied and not renamed. I'd like to discuss this with you before anything gets merged.
Baelx
force-pushed
the
feature/deseng666
branch
from
ac0b705 to
1d86b4b
Compare
|
Issue #: https://citz-gdx.atlassian.net/browse/DESENG-666
Description of changes:
**You can ignore anything under the old-view or public directories. Git didn't understand that I just wanted to move things around.
User Guide update ticket (if applicable): N/A