Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[To Main / DESENG-580] Serialize data for compatibility with new Axios version #2454

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

NatSquared
Copy link
Contributor

Issue #: 🎟️ DESENG-580

Description of changes:

  • Bugfix: Stop Axios from trying to be a smarty pants and sending data in a format Flask doesn't understand
    • This was preventing the filtering feature from working
    • Directly serialize any metadata filters before the request to avoid Axios's new nested object serialization
    • Deserialize it again on the Flask side

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@NatSquared NatSquared changed the title Serialization Take 1 DESENG-580: Serialize data for compatibility with new Axios version Apr 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.60%. Comparing base (5825b43) to head (7b9df95).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2454      +/-   ##
==========================================
- Coverage   75.60%   75.60%   -0.01%     
==========================================
  Files         582      582              
  Lines       20793    20794       +1     
  Branches     1529     1529              
==========================================
  Hits        15721    15721              
- Misses       4826     4827       +1     
  Partials      246      246              
Flag Coverage Δ
metapi 88.01% <75.00%> (-0.01%) ⬇️
metweb 63.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
met-web/src/components/landing/LandingContext.tsx 16.27% <ø> (ø)
met-web/src/services/engagementService/index.ts 27.77% <ø> (ø)
met-api/src/met_api/resources/engagement.py 98.87% <75.00%> (-1.13%) ⬇️

@NatSquared NatSquared requested a review from Baelx April 9, 2024 21:30
@NatSquared NatSquared changed the title DESENG-580: Serialize data for compatibility with new Axios version [To Main / DESENG-580] Serialize data for compatibility with new Axios version Apr 9, 2024
Copy link
Collaborator

@Baelx Baelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@NatSquared NatSquared merged commit f88e4c7 into main Apr 10, 2024
15 checks passed
@NatSquared NatSquared deleted the bugfix/DESENG-580-fix-filter-serialization branch April 22, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants