[ To Main ] - DESENG-508 - Updated Keycloak unit test for new CSS API #2443
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2443 +/- ##
==========================================
+ Coverage 74.77% 75.66% +0.88%
==========================================
Files 577 577
Lines 20578 20563 -15
Branches 1494 1494
==========================================
+ Hits 15388 15558 +170
+ Misses 4956 4771 -185
Partials 234 234
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@ratheesh-aot So given the recent development that we won't be using the CSS API anymore, do you think any of this work can be preserved for later? 😓 |
|
@Baelx Some API tests can be useful again. Also to make sure all tests are working until we start on the new Role ticket and to make sure some redundant "add to group " functionalities are removed, we may merge this PR for now. And update it later |
| KEYCLOAK_SERVICE = KeycloakService() | ||
|
|
||
|
|
||
| @pytest.fixture() |
There was a problem hiding this comment.
Is this patch intended to run before each function? If so, maybe explicitly specify fixture(scope='function'). If not, specify another scope such as module
There was a problem hiding this comment.
@NatSquared Thanks for notifying this. When I checked the default scope of the fixture will be function always. We need that because we have a test named def test_get_admin_token(mock_post) that checks whether _get_admin_token is called once or not. Also, all other test functions require this patch. That is why I left it to default scope which is function.
| @@ -76,31 +75,6 @@ def get_users_roles(self, user_ids: List): | |||
|
|
|||
| return user_role_mapping | |||
|
|
|||
| # @staticmethod | |||
There was a problem hiding this comment.
thanks for cleaning up all these comments!
Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-508
Description of changes:
Updated Keycloak Unit Tests for New CSS API Integration.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).