Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[To Main] DESENG-515: Multi-language - Create event, subcribe_item, poll, timeline widget translation tables & API routes #2421

Merged
merged 21 commits into from
Mar 15, 2024

Conversation

ratheesh-aot
Copy link
Collaborator

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-515

Description of changes:

  • Added Poll answer translation API.
  • Added Timeline Event translation API.
  • Added Subscribe Item translation API.
  • Added Event item translation API
  • Added Unit tests.

Feature PR approved

#2414 - Approved
#2416 - Approved
#2418 - Approved

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 87.70282% with 144 lines in your changes are missing coverage. Please review.

Project coverage is 75.40%. Comparing base (8366029) to head (09e929a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2421      +/-   ##
==========================================
+ Coverage   74.65%   75.40%   +0.74%     
==========================================
  Files         537      557      +20     
  Lines       18555    19632    +1077     
  Branches     1349     1347       -2     
==========================================
+ Hits        13852    14803     +951     
- Misses       4496     4622     +126     
  Partials      207      207              
Flag Coverage Δ
metapi 85.89% <87.70%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
met-api/src/met_api/auth.py 100.00% <100.00%> (ø)
met-api/src/met_api/models/__init__.py 100.00% <100.00%> (ø)
met-api/src/met_api/resources/__init__.py 100.00% <100.00%> (ø)
...t-api/src/met_api/resources/engagement_metadata.py 83.18% <100.00%> (+2.57%) ⬆️
met-api/src/met_api/resources/metadata_taxon.py 88.23% <100.00%> (+0.53%) ⬆️
met-api/src/met_api/schemas/engagement_metadata.py 82.00% <100.00%> (+2.00%) ⬆️
...-api/src/met_api/schemas/engagement_translation.py 100.00% <100.00%> (ø)
...c/met_api/schemas/event_item_translation_schema.py 100.00% <100.00%> (ø)
.../met_api/schemas/poll_answer_translation_schema.py 100.00% <100.00%> (ø)
...t_api/schemas/subscribe_item_translation_schema.py 100.00% <100.00%> (ø)
... and 33 more

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ratheesh-aot ratheesh-aot merged commit 437b133 into main Mar 15, 2024
11 checks passed
@ratheesh-aot ratheesh-aot deleted the DESENG-515-MultiLangEventFinal branch March 15, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants