Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TO MAIN] DESENG-511 - Survey Translation model and API #2410

Merged
merged 8 commits into from
Mar 8, 2024

Conversation

ratheesh-aot
Copy link
Collaborator

@ratheesh-aot ratheesh-aot commented Mar 8, 2024

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-511

Description of changes:

Feature PR
#2408 - Approved
#2406 - Approved

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@ratheesh-aot ratheesh-aot requested a review from NatSquared March 8, 2024 00:52
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 82.81250% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 74.32%. Comparing base (122d391) to head (ba05a96).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2410      +/-   ##
==========================================
+ Coverage   74.23%   74.32%   +0.08%     
==========================================
  Files         533      537       +4     
  Lines       18202    18394     +192     
  Branches     1344     1344              
==========================================
+ Hits        13512    13671     +159     
- Misses       4481     4514      +33     
  Partials      209      209              
Flag Coverage Δ
metapi 85.55% <82.81%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
met-api/src/met_api/models/__init__.py 100.00% <100.00%> (ø)
met-api/src/met_api/resources/__init__.py 100.00% <100.00%> (ø)
...i/src/met_api/schemas/survey_translation_schema.py 100.00% <100.00%> (ø)
met-api/src/met_api/models/survey_translation.py 95.45% <95.45%> (ø)
...src/met_api/services/survey_translation_service.py 84.31% <84.31%> (ø)
...et-api/src/met_api/resources/survey_translation.py 71.95% <71.95%> (ø)

@ratheesh-aot ratheesh-aot merged commit 74f835a into main Mar 8, 2024
11 checks passed
@ratheesh-aot ratheesh-aot deleted the DESENG-511-SurveyTranslation-Final branch March 8, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants