Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TO MAIN] DESENG-507 - Engagement save enhancements #2409

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

VineetBala-AOT
Copy link
Collaborator

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-507

Description of changes:

  • The existing "Save" button in the floating bar has been split into two distinct actions: "Save and Continue" and "Save and Exit".
  • Tabs are greyed out, and widgets are disabled until the engagement is successfully saved. A helpful tool-tip has been added to inform users that the engagement needs to be saved before accessing certain features.
  • Independent save buttons previously present in tabs, such as "Additional Details", "Settings" have been removed. Now, the floating save bar is universally employed when editing an engagement.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 68.10345% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 74.37%. Comparing base (122d391) to head (b319bf2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2409      +/-   ##
==========================================
+ Coverage   74.23%   74.37%   +0.14%     
==========================================
  Files         533      529       -4     
  Lines       18202    18140      -62     
  Branches     1344     1349       +5     
==========================================
- Hits        13512    13492      -20     
+ Misses       4481     4441      -40     
+ Partials      209      207       -2     
Flag Coverage Δ
metweb 64.19% <68.10%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ts/engagement/form/EngagementFormTabs/FormTabs.tsx 100.00% <100.00%> (ø)
...ment/form/EngagementFormTabs/SurveyBlock/index.tsx 63.41% <100.00%> (-0.88%) ⬇️
...engagement/form/EngagementWidgets/WidgetsBlock.tsx 78.00% <100.00%> (+2.52%) ⬆️
...t-web/src/services/engagementSlugService/index.tsx 40.00% <ø> (ø)
...agement/form/EngagementFormTabs/EngagementForm.tsx 85.00% <80.00%> (-1.67%) ⬇️
...nt/form/EngagementFormTabs/Settings/PublicUrls.tsx 63.26% <80.00%> (+11.87%) ⬆️
...ormTabs/AdditionalDetails/AdditionalTabContent.tsx 80.00% <33.33%> (-7.50%) ⬇️
...ementFormTabs/AdditionalDetails/ConsentMessage.tsx 88.88% <81.81%> (-2.78%) ⬇️
...gementFormTabs/Settings/EngagementSettingsForm.tsx 81.25% <33.33%> (-6.99%) ⬇️
...EngagementFormTabs/Settings/InternalEngagement.tsx 88.23% <81.81%> (-3.44%) ⬇️
... and 4 more

@VineetBala-AOT VineetBala-AOT marked this pull request as ready for review March 7, 2024 21:20
@VineetBala-AOT VineetBala-AOT merged commit 966fc28 into main Mar 7, 2024
8 checks passed
@VineetBala-AOT VineetBala-AOT deleted the feature/deseng-507-final branch March 8, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants