Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TO MAIN] DESENG-509 - Language model and API #2404

Merged
merged 12 commits into from
Mar 4, 2024

Conversation

ratheesh-aot
Copy link
Collaborator

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-509

Description of changes:
Added Language model. - Reviewed
Added Language API. - Reviewed
Added Unit tests. - Reviewed
Changelog Added - In Review

Feature PR's

  https://github.com/bcgov/met-public/pull/2399 - Merged
  https://github.com/bcgov/met-public/pull/2400 - Merged
  
  https://github.com/bcgov/met-public/pull/2402 - Merged
  https://github.com/bcgov/met-public/pull/2403 - Merged

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@ratheesh-aot ratheesh-aot requested a review from Baelx March 4, 2024 21:14
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 74.23%. Comparing base (d3440c1) to head (271ab0d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2404      +/-   ##
==========================================
+ Coverage   74.15%   74.23%   +0.07%     
==========================================
  Files         529      533       +4     
  Lines       18046    18202     +156     
  Branches     1344     1344              
==========================================
+ Hits        13382    13512     +130     
- Misses       4455     4481      +26     
  Partials      209      209              
Flag Coverage Δ
metapi 85.61% <83.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
met-api/src/met_api/models/__init__.py 100.00% <100.00%> (ø)
met-api/src/met_api/resources/__init__.py 100.00% <100.00%> (ø)
met-api/src/met_api/schemas/language.py 100.00% <100.00%> (ø)
met-api/src/met_api/models/language.py 97.14% <97.14%> (ø)
met-api/src/met_api/services/language_service.py 86.66% <86.66%> (ø)
met-api/src/met_api/resources/language.py 73.75% <73.75%> (ø)

@ratheesh-aot ratheesh-aot merged commit 122d391 into main Mar 4, 2024
11 checks passed
@ratheesh-aot ratheesh-aot deleted the DESENG-509-LANGUAGE-FINAL branch March 4, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants