Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESENG-473: Restore role assignment functionality #2385

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

VineetBala-AOT
Copy link
Collaborator

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-473

Description of changes:

  • Utilize the CSS API for efficient management of composite roles. This involves the assignment, reassignment, or removal of users from the composite roles of TEAM_MEMBER, REVIEWER, IT_ADMIN, or IT_VIEWER.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: 167 lines in your changes are missing coverage. Please review.

Comparison is base (1bac246) 71.82% compared to head (927f38c) 71.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2385      +/-   ##
==========================================
- Coverage   71.82%   71.27%   -0.56%     
==========================================
  Files         509      509              
  Lines       16915    17063     +148     
  Branches     1288     1288              
==========================================
+ Hits        12149    12161      +12     
- Misses       4526     4662     +136     
  Partials      240      240              
Flag Coverage Δ
metapi 85.00% <32.35%> (-1.45%) ⬇️
metweb 59.13% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
met-api/src/met_api/config.py 97.29% <ø> (+0.03%) ⬆️
met-web/src/apiManager/endpoints/index.ts 100.00% <ø> (ø)
...ponents/userManagement/userDetails/UserDetails.tsx 93.33% <100.00%> (ø)
...ts/userManagement/userDetails/UserStatusButton.tsx 57.89% <100.00%> (ø)
met-web/src/models/user.ts 100.00% <100.00%> (ø)
...nents/comments/admin/reviewListing/Submissions.tsx 81.81% <50.00%> (ø)
...rc/components/comments/admin/textListing/index.tsx 80.00% <50.00%> (ø)
...components/userManagement/listing/AddUserModal.tsx 44.82% <0.00%> (ø)
...s/userManagement/listing/UserManagementListing.tsx 64.51% <0.00%> (ø)
...nents/userManagement/listing/ReassignRoleModal.tsx 68.42% <50.00%> (ø)
... and 11 more

... and 1 file with indirect coverage changes

Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@VineetBala-AOT VineetBala-AOT marked this pull request as ready for review February 15, 2024 23:00
@VineetBala-AOT VineetBala-AOT merged commit ca06c76 into main Feb 15, 2024
15 checks passed
@VineetBala-AOT VineetBala-AOT deleted the feature/deseng-473 branch February 15, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants