DESENG-484: Adding max age for cors #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DESENG-484: Adding max age for cors
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2379 +/- ##
=======================================
Coverage 71.80% 71.81%
=======================================
Files 509 509
Lines 16916 16921 +5
Branches 1288 1288
=======================================
+ Hits 12147 12152 +5
Misses 4529 4529
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I'm guessing this PR was submitted again due to a merging error? |
Baelx
approved these changes
Feb 12, 2024
|
NatSquared
pushed a commit
that referenced
this pull request
Feb 12, 2024
* DESENG-484: Adding max age for cors (#2377)
ratheesh-aot
pushed a commit
to ratheesh-aot/met-public
that referenced
this pull request
Feb 16, 2024
* DESENG-484: Adding max age for cors (bcgov#2377)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-484
Description of changes:
- Introduces a new configuration variable to specify the maximum age for Cross-Origin Resource Sharing (CORS)
- Modified the CORS preflight method to utilize this newly introduced variable.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).