Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESENG-452 : Applying pending migrations #2378

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

ratheesh-aot
Copy link
Collaborator

Issue: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-452

Description of changes:

  1. Change some foreign key field to nullbale false in model files
    
  2. Change `rejected_reason_other` to nullable true in `submission` model
    
  3. Generated new migration file based on the pending model changes which confirmed to be valid
    
  4. Updated Unittest of Email verification to send `type` to the api
    

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (23faaae) 71.80% compared to head (2d80b6e) 71.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2378      +/-   ##
==========================================
+ Coverage   71.80%   71.82%   +0.01%     
==========================================
  Files         509      509              
  Lines       16916    16916              
  Branches     1288     1288              
==========================================
+ Hits        12147    12150       +3     
+ Misses       4529     4526       -3     
  Partials      240      240              
Flag Coverage Δ
metapi 86.45% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
met-api/src/met_api/models/submission.py 80.21% <100.00%> (ø)
met-api/src/met_api/models/timeline_event.py 75.00% <100.00%> (ø)
met-api/src/met_api/models/widget_timeline.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ratheesh-aot ratheesh-aot merged commit be8dad4 into bcgov:main Feb 9, 2024
11 checks passed
NatSquared pushed a commit that referenced this pull request Feb 12, 2024
* DESENG-452 : Applying pending migrations

* Updating unit test

* Updated changelog

* Fixed lint issue
NatSquared pushed a commit that referenced this pull request Feb 12, 2024
* DESENG-452 : Applying pending migrations

* Updating unit test

* Updated changelog

* Fixed lint issue
NatSquared pushed a commit that referenced this pull request Feb 12, 2024
* DESENG-452 : Applying pending migrations

* Updating unit test

* Updated changelog

* Fixed lint issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants