DESENG-447 : Convert keycloak groups to composite roles for permission levels #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2376 +/- ##
==========================================
- Coverage 72.21% 71.81% -0.41%
==========================================
Files 509 509
Lines 17130 16915 -215
Branches 1288 1288
==========================================
- Hits 12370 12147 -223
- Misses 4520 4528 +8
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Baelx
requested changes
Feb 7, 2024
| @@ -14,19 +14,19 @@ | |||
|
|
|||
| """Tests to verify the user membership operations. | |||
|
|
|||
| Test-Suite to ensure that the user membership endpoints are working as expected. | |||
| Test-Suite to ensure that the user membership endpoints are working as expected. # noqa: E501 | |||
There was a problem hiding this comment.
some codes and docstrings exceeded the max length when we commented it out that's why there is a # noqa: E501 to ignore that flake8 warning for the time being as we are gonna uncomment those functions in the near future
| @@ -36,6 +36,7 @@ import { HTTP_STATUS_CODES } from 'constants/httpResponseCodes'; | |||
| export const AddToEngagementModal = () => { | |||
| const { savedUser, addUserModalOpen, setAddUserModalOpen, getUserMemberships, getUserDetails } = | |||
| useContext(UserDetailsContext); | |||
| console.log('user', savedUser); | |||
There was a problem hiding this comment.
We can remove the logging for now. I should mentioned some calls were still present in the code
|
Baelx
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-447
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).