Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating migration file for engagement metadata #2368

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

VineetBala-AOT
Copy link
Collaborator

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-471

Description of changes:

  • Updating engagement metadata migration file which is causing a CD error for met-api

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a9d5735) 60.45% compared to head (a74ba60) 73.23%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2368       +/-   ##
===========================================
+ Coverage   60.45%   73.23%   +12.77%     
===========================================
  Files         314      498      +184     
  Lines        8671    16748     +8077     
  Branches     1227     1227               
===========================================
+ Hits         5242    12265     +7023     
- Misses       3205     4259     +1054     
  Partials      224      224               
Flag Coverage Δ
metapi 86.93% <91.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
met-api/src/met_api/__init__.py 93.75% <ø> (ø)
met-api/src/met_api/auth.py 100.00% <100.00%> (ø)
met-api/src/met_api/models/__init__.py 100.00% <100.00%> (ø)
met-api/src/met_api/models/engagement_metadata.py 79.16% <ø> (ø)
met-api/src/met_api/resources/__init__.py 100.00% <100.00%> (ø)
...t-api/src/met_api/resources/engagement_metadata.py 80.61% <100.00%> (ø)
met-api/src/met_api/resources/metadata_taxon.py 87.70% <100.00%> (ø)
met-api/src/met_api/schemas/engagement_metadata.py 80.00% <100.00%> (ø)
met-api/src/met_api/services/authorization.py 88.88% <ø> (ø)
...rc/met_api/services/engagement_metadata_service.py 83.58% <100.00%> (ø)
... and 3 more

... and 173 files with indirect coverage changes

@NatSquared NatSquared self-requested a review January 29, 2024 21:38
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@VineetBala-AOT VineetBala-AOT marked this pull request as ready for review January 30, 2024 04:17
@VineetBala-AOT VineetBala-AOT merged commit ed80ca2 into bcgov:main Jan 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants