Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to fix default deployment to GDX #2364

Merged
merged 42 commits into from
Jan 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
1dbaf8b
Changes to show all survey results to superusers
VineetBala-AOT Aug 25, 2023
4c6362a
removing hard coded values
VineetBala-AOT Aug 26, 2023
6d6d8a5
fixing linting
VineetBala-AOT Aug 26, 2023
492a93b
splitting to seperate end points
VineetBala-AOT Aug 28, 2023
3a63dcd
Handle no data error for graphs
VineetBala-AOT Aug 28, 2023
0fa422c
adding new nodata component
VineetBala-AOT Aug 30, 2023
8c020fb
adding new email for submission response
VineetBala-AOT Sep 1, 2023
8abdfb7
fixing linting and testing
VineetBala-AOT Sep 2, 2023
ee1be34
Upgrades to Issue Tracking Table
VineetBala-AOT Sep 14, 2023
ed2bd54
removing try catch
VineetBala-AOT Sep 14, 2023
4b3ee3d
removing changes for email verification
VineetBala-AOT Sep 26, 2023
40a7257
updating
VineetBala-AOT Sep 27, 2023
469b6cb
Merging bug fixes from epic engage
VineetBala-AOT Jan 3, 2024
201506b
Updating comment service to remove metadata
VineetBala-AOT Jan 8, 2024
5256239
Updating comment
VineetBala-AOT Jan 9, 2024
6efeca9
Changes to show all survey results to superusers
VineetBala-AOT Aug 25, 2023
6598a3a
removing hard coded values
VineetBala-AOT Aug 26, 2023
ffd341d
fixing linting
VineetBala-AOT Aug 26, 2023
b0191a2
splitting to seperate end points
VineetBala-AOT Aug 28, 2023
9f67112
Handle no data error for graphs
VineetBala-AOT Aug 28, 2023
b563f2f
adding new nodata component
VineetBala-AOT Aug 30, 2023
c435f0d
adding new email for submission response
VineetBala-AOT Sep 1, 2023
c9c05fa
fixing linting and testing
VineetBala-AOT Sep 2, 2023
918de94
Upgrades to Issue Tracking Table
VineetBala-AOT Sep 14, 2023
d94a6ef
removing try catch
VineetBala-AOT Sep 14, 2023
1164485
removing changes for email verification
VineetBala-AOT Sep 26, 2023
80e0bda
updating
VineetBala-AOT Sep 27, 2023
c45a53b
Merging bug fixes from epic engage
VineetBala-AOT Jan 3, 2024
7933efa
Updating comment service to remove metadata
VineetBala-AOT Jan 8, 2024
4450b83
Changes for Custom Consent per Engagement
VineetBala-AOT Jan 10, 2024
628836e
removing unused import
VineetBala-AOT Jan 10, 2024
12f4738
Removing character count
VineetBala-AOT Jan 10, 2024
5bae66c
Fixing unit tests
VineetBala-AOT Jan 12, 2024
c108df7
Updating all api unit test fixes
VineetBala-AOT Jan 12, 2024
c012bdf
Fixing remaining unit tests
VineetBala-AOT Jan 12, 2024
d12d968
Adding unit tests for met api
VineetBala-AOT Jan 18, 2024
055fb8d
Updating role claims for test scenarios
VineetBala-AOT Jan 18, 2024
fe40af3
Reverting to old role
VineetBala-AOT Jan 18, 2024
1fc91fc
Add more unit tests and changing role claim
VineetBala-AOT Jan 19, 2024
0987fb5
Removing unwanted enum
VineetBala-AOT Jan 22, 2024
1a9a274
Setting the default project in CD files
VineetBala-AOT Jan 24, 2024
05c1b65
Removing project type
VineetBala-AOT Jan 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions .github/workflows/analytics-api-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ on:
description: "Environment (dev/test/prod)"
required: true
default: "dev"
project_type:
description: "Project Type (EAO/GDX)"
required: false
default: "EAO" # Default value is EAO

defaults:
run:
Expand All @@ -26,13 +22,12 @@ defaults:
env:
APP_NAME: "analytics-api"
TAG_NAME: "${{github.event.inputs.environment || 'dev' }}" # If the environment type is manually selected, use the input value; otherwise, use 'dev' as default
PROJECT_TYPE: "${{ github.event.inputs.project_type || 'EAO' }}" # If the project type is manually selected, use the input value; otherwise, use 'EAO' as default

OPENSHIFT_LOGIN_REGISTRY: ${{ secrets.OPENSHIFT_LOGIN_REGISTRY }}
OPENSHIFT_SA_TOKEN: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_SA_TOKEN || secrets.OPENSHIFT_SA_TOKEN_EAO }}
OPENSHIFT_SA_NAME: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_SA_NAME || secrets.OPENSHIFT_SA_NAME_EAO }}
OPENSHIFT_IMAGE_REGISTRY: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_IMAGE_REGISTRY || secrets.OPENSHIFT_IMAGE_REGISTRY_EAO }}
OPENSHIFT_REPOSITORY: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_REPOSITORY || secrets.OPENSHIFT_REPOSITORY_EAO }}
OPENSHIFT_SA_TOKEN: ${{ secrets.OPENSHIFT_SA_TOKEN }}
OPENSHIFT_SA_NAME: ${{ secrets.OPENSHIFT_SA_NAME }}
OPENSHIFT_IMAGE_REGISTRY: ${{ secrets.OPENSHIFT_IMAGE_REGISTRY }}
OPENSHIFT_REPOSITORY: ${{ secrets.OPENSHIFT_REPOSITORY }}

jobs:
analytics-api-cd:
Expand Down
10 changes: 2 additions & 8 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ on:
description: "Environment (test/prod)"
required: true
default: "test"
project_type:
description: "Project Type (EAO/GDX)"
required: false
default: "GDX" # Default value is GDX

defaults:
run:
Expand All @@ -19,12 +15,10 @@ defaults:

env:
TAG_NAME: "${{ github.event.inputs.environment || 'test' }}" # If the environment type is manually selected, use the input value; otherwise, use 'test' as default
PROJECT_TYPE: "${{ github.event.inputs.project_type || 'GDX' }}" # If the project type is manually selected, use the input value; otherwise, use 'GDX' as default

# Set OpenShift related variables based on PROJECT_TYPE
OPENSHIFT_LOGIN_REGISTRY: ${{ secrets.OPENSHIFT_LOGIN_REGISTRY }}
OPENSHIFT_SA_TOKEN: ${{ (github.event.inputs.project_type == 'EAO') && secrets.OPENSHIFT_SA_TOKEN_EAO || secrets.OPENSHIFT_SA_TOKEN }}
OPENSHIFT_REPOSITORY: ${{ (github.event.inputs.project_type == 'EAO') && secrets.OPENSHIFT_REPOSITORY_EAO || secrets.OPENSHIFT_REPOSITORY }}
OPENSHIFT_SA_TOKEN: ${{ secrets.OPENSHIFT_SA_TOKEN }}
OPENSHIFT_REPOSITORY: ${{ secrets.OPENSHIFT_REPOSITORY }}

jobs:
met-deployment:
Expand Down
16 changes: 5 additions & 11 deletions .github/workflows/met-api-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,7 @@ on:
environment:
description: "Environment (dev/test/prod)"
required: true
default: "dev"
project_type:
description: "Project Type (EAO/GDX)"
required: false
default: "EAO" # Default value is EAO
default: "dev"

defaults:
run:
Expand All @@ -26,14 +22,12 @@ defaults:
env:
APP_NAME: "met-api"
TAG_NAME: "${{ github.event.inputs.environment || 'dev' }}" # If the environment type is manually selected, use the input value; otherwise, use 'dev' as default
PROJECT_TYPE: "${{ github.event.inputs.project_type || 'EAO' }}" # If the project type is manually selected, use the input value; otherwise, use 'EAO' as default

# Set OpenShift related variables based on PROJECT_TYPE
OPENSHIFT_LOGIN_REGISTRY: ${{ secrets.OPENSHIFT_LOGIN_REGISTRY }}
OPENSHIFT_SA_TOKEN: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_SA_TOKEN || secrets.OPENSHIFT_SA_TOKEN_EAO }}
OPENSHIFT_SA_NAME: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_SA_NAME || secrets.OPENSHIFT_SA_NAME_EAO }}
OPENSHIFT_IMAGE_REGISTRY: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_IMAGE_REGISTRY || secrets.OPENSHIFT_IMAGE_REGISTRY_EAO }}
OPENSHIFT_REPOSITORY: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_REPOSITORY || secrets.OPENSHIFT_REPOSITORY_EAO }}
OPENSHIFT_SA_TOKEN: ${{ secrets.OPENSHIFT_SA_TOKEN }}
OPENSHIFT_SA_NAME: ${{ secrets.OPENSHIFT_SA_NAME }}
OPENSHIFT_IMAGE_REGISTRY: ${{ secrets.OPENSHIFT_IMAGE_REGISTRY }}
OPENSHIFT_REPOSITORY: ${{ secrets.OPENSHIFT_REPOSITORY }}


jobs:
Expand Down
15 changes: 5 additions & 10 deletions .github/workflows/met-cron-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,7 @@ on:
environment:
description: "Environment (dev/test/prod)"
required: true
default: "dev"
project_type:
description: "Project Type (EAO/GDX)"
required: false
default: "EAO" # Default value is EAO
default: "dev"

defaults:
run:
Expand All @@ -27,13 +23,12 @@ defaults:
env:
APP_NAME: "met-cron"
TAG_NAME: "${{github.event.inputs.environment || 'dev' }}" # If the environment type is manually selected, use the input value; otherwise, use 'dev' as default
PROJECT_TYPE: "${{ github.event.inputs.project_type || 'EAO' }}" # If the project type is manually selected, use the input value; otherwise, use 'EAO' as default

OPENSHIFT_LOGIN_REGISTRY: ${{ secrets.OPENSHIFT_LOGIN_REGISTRY }}
OPENSHIFT_SA_TOKEN: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_SA_TOKEN || secrets.OPENSHIFT_SA_TOKEN_EAO }}
OPENSHIFT_SA_NAME: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_SA_NAME || secrets.OPENSHIFT_SA_NAME_EAO }}
OPENSHIFT_IMAGE_REGISTRY: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_IMAGE_REGISTRY || secrets.OPENSHIFT_IMAGE_REGISTRY_EAO }}
OPENSHIFT_REPOSITORY: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_REPOSITORY || secrets.OPENSHIFT_REPOSITORY_EAO }}
OPENSHIFT_SA_TOKEN: ${{ secrets.OPENSHIFT_SA_TOKEN }}
OPENSHIFT_SA_NAME: ${{ secrets.OPENSHIFT_SA_NAME }}
OPENSHIFT_IMAGE_REGISTRY: ${{ secrets.OPENSHIFT_IMAGE_REGISTRY }}
OPENSHIFT_REPOSITORY: ${{ secrets.OPENSHIFT_REPOSITORY }}


jobs:
Expand Down
16 changes: 5 additions & 11 deletions .github/workflows/met-etl-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,7 @@ on:
environment:
description: "Environment (dev/test/prod)"
required: true
default: "dev"
project_type:
description: "Project Type (EAO/GDX)"
required: false
default: "EAO" # Default value is EAO
default: "dev"

defaults:
run:
Expand All @@ -28,14 +24,12 @@ env:
APP_NAME: "dagster-etl"
DEPLOYMENT_NAME: "dagster-dagster-user-deployments-etl"
TAG_NAME: "dev"

PROJECT_TYPE: "${{ github.event.inputs.project_type || 'EAO' }}" # If the project type is manually selected, use the input value; otherwise, use 'EAO' as default

OPENSHIFT_LOGIN_REGISTRY: ${{ secrets.OPENSHIFT_LOGIN_REGISTRY }}
OPENSHIFT_SA_TOKEN: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_SA_TOKEN || secrets.OPENSHIFT_SA_TOKEN_EAO }}
OPENSHIFT_SA_NAME: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_SA_NAME || secrets.OPENSHIFT_SA_NAME_EAO }}
OPENSHIFT_IMAGE_REGISTRY: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_IMAGE_REGISTRY || secrets.OPENSHIFT_IMAGE_REGISTRY_EAO }}
OPENSHIFT_REPOSITORY: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_REPOSITORY || secrets.OPENSHIFT_REPOSITORY_EAO }}
OPENSHIFT_SA_TOKEN: ${{ secrets.OPENSHIFT_SA_TOKEN }}
OPENSHIFT_SA_NAME: ${{ secrets.OPENSHIFT_SA_NAME }}
OPENSHIFT_IMAGE_REGISTRY: ${{ secrets.OPENSHIFT_IMAGE_REGISTRY }}
OPENSHIFT_REPOSITORY: ${{ secrets.OPENSHIFT_REPOSITORY }}

jobs:
met-cron-cd:
Expand Down
14 changes: 4 additions & 10 deletions .github/workflows/met-web-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ on:
description: "Environment (dev/test/prod)"
required: true
default: "dev"
project_type:
description: "Project Type (EAO/GDX)"
required: false
default: "EAO" # Default value is EAO

defaults:
run:
Expand All @@ -26,14 +22,12 @@ defaults:
env:
APP_NAME: "met-web"
TAG_NAME: "${{ github.event.inputs.environment || 'dev' }}" # If the environment type is manually selected, use the input value; otherwise, use 'dev' as default

PROJECT_TYPE: "${{ github.event.inputs.project_type || 'EAO' }}" # If the project type is manually selected, use the input value; otherwise, use 'EAO' as default

OPENSHIFT_LOGIN_REGISTRY: ${{ secrets.OPENSHIFT_LOGIN_REGISTRY }}
OPENSHIFT_SA_TOKEN: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_SA_TOKEN || secrets.OPENSHIFT_SA_TOKEN_EAO }}
OPENSHIFT_SA_NAME: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_SA_NAME || secrets.OPENSHIFT_SA_NAME_EAO }}
OPENSHIFT_IMAGE_REGISTRY: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_IMAGE_REGISTRY || secrets.OPENSHIFT_IMAGE_REGISTRY_EAO }}
OPENSHIFT_REPOSITORY: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_REPOSITORY || secrets.OPENSHIFT_REPOSITORY_EAO }}
OPENSHIFT_SA_TOKEN: ${{ secrets.OPENSHIFT_SA_TOKEN }}
OPENSHIFT_SA_NAME: ${{ secrets.OPENSHIFT_SA_NAME }}
OPENSHIFT_IMAGE_REGISTRY: ${{ secrets.OPENSHIFT_IMAGE_REGISTRY }}
OPENSHIFT_REPOSITORY: ${{ secrets.OPENSHIFT_REPOSITORY }}

jobs:
met-web-cd:
Expand Down
14 changes: 4 additions & 10 deletions .github/workflows/notify-api-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ on:
description: "Environment (dev/test/prod)"
required: true
default: "dev"
project_type:
description: "Project Type (EAO/GDX)"
required: false
default: "EAO" # Default value is EAO

defaults:
run:
Expand All @@ -27,13 +23,11 @@ env:
APP_NAME: "notify-api"
TAG_NAME: "${{ github.event.inputs.environment || 'dev' }}" # If the environment type is manually selected, use the input value; otherwise, use 'dev' as default

PROJECT_TYPE: "${{ github.event.inputs.project_type || 'EAO' }}" # If the project type is manually selected, use the input value; otherwise, use 'EAO' as default

OPENSHIFT_LOGIN_REGISTRY: ${{ secrets.OPENSHIFT_LOGIN_REGISTRY }}
OPENSHIFT_SA_TOKEN: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_SA_TOKEN || secrets.OPENSHIFT_SA_TOKEN_EAO }}
OPENSHIFT_SA_NAME: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_SA_NAME || secrets.OPENSHIFT_SA_NAME_EAO }}
OPENSHIFT_IMAGE_REGISTRY: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_IMAGE_REGISTRY || secrets.OPENSHIFT_IMAGE_REGISTRY_EAO }}
OPENSHIFT_REPOSITORY: ${{ github.event.inputs.project_type == 'GDX' && secrets.OPENSHIFT_REPOSITORY || secrets.OPENSHIFT_REPOSITORY_EAO }}
OPENSHIFT_SA_TOKEN: ${{ secrets.OPENSHIFT_SA_TOKEN }}
OPENSHIFT_SA_NAME: ${{ secrets.OPENSHIFT_SA_NAME }}
OPENSHIFT_IMAGE_REGISTRY: ${{ secrets.OPENSHIFT_IMAGE_REGISTRY }}
OPENSHIFT_REPOSITORY: ${{ secrets.OPENSHIFT_REPOSITORY }}

jobs:
notify-api-cd:
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.MD
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## January 24, 2024
- **Task** Update default project type to GDX for all deployments by default. [🎟️DESENG-472](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-472)
- Set the default project type to GDX on all continuous deployment (CD) files.
- Removed the option to deploy to EAO.

## January 22, 2024
- **Task** Add missing unit tests for met api [🎟️DESENG-481](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-481)
- Added missing unit tests for met api
Expand Down
Loading