-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/deseng415 #2334
Feature/deseng415 #2334
Conversation
…nd displaying the data on admin side.
Codecov Report
@@ Coverage Diff @@
## gdx-dev #2334 +/- ##
==========================================
Coverage ? 68.56%
==========================================
Files ? 472
Lines ? 15598
Branches ? 1193
==========================================
Hits ? 10694
Misses ? 4695
Partials ? 209
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple things to check in your schemas but overall looks good!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great; I appreciate the attention to detail. Approved 🎉
* feature/deseng415: Added recording of date with feedback submission and displaying the data on admin side. * feature/deseng415: Fixed feedback schema, removed yup import, fixed change log date.
* feature/deseng415: Added recording of date with feedback submission and displaying the data on admin side. * feature/deseng415: Fixed feedback schema, removed yup import, fixed change log date.
* Feature: SSO Migration - DESENG #408 (#2333) * Make role checks platform-agnostic * default to standard realm * Remove local Keycloak instances and config * Use tenant information from DB instead of Keycloak * Update sample.env files * Clean up the changelog... and we're good to go! 🥳 * [DESENG-414] .env var (and config) audit and cleanup (#2339) * Overhaul of most configuration files * No longer using semver; update CHANGELOG.MD * Feature/deseng415 (#2334) * feature/deseng415: Added recording of date with feedback submission and displaying the data on admin side. * feature/deseng415: Fixed feedback schema, removed yup import, fixed change log date. * bugfix/deseng429: Removed outdated service class. (#2337) * bugfix/deseng429: Removed outdated service class. * bugfix/deseng429: Changed version and changelog to match deployments to gdx-main. * DESENG-438 Superusers can publish engagements without attached surveys (#2338) * DESENG-441 Remove unused engagement metadata fields (#2340) * Fixed merge errors in the changelog --------- Co-authored-by: jareth-whitney <[email protected]> Co-authored-by: Baelx <[email protected]> Co-authored-by: Alex <[email protected]> Well done team! 💖
* Bugfix/deseng413 (#2330) * bugfix/deseng413: Upgraded BC-Sans font to newest version. * bugfix/deseng413: Small update to changelog for clarification. * Feature: SSO Migration - DESENG #408 (#2333) * Make role checks platform-agnostic * default to standard realm * Remove local Keycloak instances and config * Use tenant information from DB instead of Keycloak * Update sample.env files * Clean up the changelog... and we're good to go! 🥳 * [DESENG-414] .env var (and config) audit and cleanup (#2339) * Overhaul of most configuration files * No longer using semver; update CHANGELOG.MD * Feature/deseng415 (#2334) * feature/deseng415: Added recording of date with feedback submission and displaying the data on admin side. * feature/deseng415: Fixed feedback schema, removed yup import, fixed change log date. * bugfix/deseng429: Removed outdated service class. (#2337) * bugfix/deseng429: Removed outdated service class. * bugfix/deseng429: Changed version and changelog to match deployments to gdx-main. * DESENG-438 Superusers can publish engagements without attached surveys (#2338) * DESENG-441 Remove unused engagement metadata fields (#2340) * Fixed merge errors in the changelog --------- Co-authored-by: jareth-whitney <[email protected]> Co-authored-by: Baelx <[email protected]> Co-authored-by: Alex <[email protected]> Well done team! 💖
* Add initial version of change log (#2318) * Feature/update sample env files (#2320) * Remove old production .env file * Update DEVELOPMENT.md to reflect project state * Update CHANGELOG.md before PR * Link JIRA ticket # on relevant changes * Bring bugfixes from main into gdx-dev (#2328) * Made slug url case insensitive , Fixed bug with wrong query join for submission (#2321) * CSV export made working for multipage wizard surveys (#2322) --------- Co-authored-by: saravanpa-aot <[email protected]> * bugfix/deseng421: Changed engagement links so that they open in the same window/tab as opposed to a new one. (#2329) * Merge SSO and dev changes into gdx-main (#2343) * Bugfix/deseng413 (#2330) * bugfix/deseng413: Upgraded BC-Sans font to newest version. * bugfix/deseng413: Small update to changelog for clarification. * Feature: SSO Migration - DESENG #408 (#2333) * Make role checks platform-agnostic * default to standard realm * Remove local Keycloak instances and config * Use tenant information from DB instead of Keycloak * Update sample.env files * Clean up the changelog... and we're good to go! 🥳 * [DESENG-414] .env var (and config) audit and cleanup (#2339) * Overhaul of most configuration files * No longer using semver; update CHANGELOG.MD * Feature/deseng415 (#2334) * feature/deseng415: Added recording of date with feedback submission and displaying the data on admin side. * feature/deseng415: Fixed feedback schema, removed yup import, fixed change log date. * bugfix/deseng429: Removed outdated service class. (#2337) * bugfix/deseng429: Changed version and changelog to match deployments to gdx-main. * DESENG-438 Superusers can publish engagements without attached surveys (#2338) * DESENG-441 Remove unused engagement metadata fields (#2340) * Fixed merge errors in the changelog --------- Co-authored-by: saravanpa-aot <[email protected]> Co-authored-by: jareth-whitney <[email protected]> Co-authored-by: Baelx <[email protected]> Co-authored-by: Alex <[email protected]> Thank you, everyone! ---------
…m Main (#2347) * Add initial version of change log (#2318) Add a change log to allow developers to log any changes they make to the project. * Feature/update sample env files (#2320) * Feature: update sample .env files * Remove old production .env file * Update DEVELOPMENT.md to reflect project state * Update CHANGELOG.md before PR * Link JIRA ticket # on relevant changes * Bring bugfixes from main into gdx-dev (#2328) * Made slug url case insensitive , Fixed bug with wrong query join for submission (#2321) * Made slug url case insensitive , Fixed bug with wrong query join for submission * removed a couple of if statements * CSV export made working for multipage wizard surveys (#2322) --------- Co-authored-by: saravanpa-aot <[email protected]> * bugfix/deseng421: Changed engagement links so that they open in the same window/tab as opposed to a new one. (#2329) * Bugfix/deseng413 (#2330) * bugfix/deseng413: Upgraded BC-Sans font to newest version. * bugfix/deseng413: Small update to changelog for clarification. * Feature/deseng415 (#2334) * feature/deseng415: Added recording of date with feedback submission and displaying the data on admin side. * feature/deseng415: Fixed feedback schema, removed yup import, fixed change log date. * bugfix/deseng429: Removed outdated service class. (#2337) * bugfix/deseng429: Removed outdated service class. * bugfix/deseng429: Changed version and changelog to match deployments to gdx-main. * feature/deseng439: Finished the Timeline Widget and linted. * feature/deseng439: Updated changelog before merge. * feature/deseng439: Made revisions as per Alex and added sorting to React components. --------- Co-authored-by: Nat² <[email protected]> Co-authored-by: saravanpa-aot <[email protected]>
…m Main (#2347) * Add initial version of change log (#2318) Add a change log to allow developers to log any changes they make to the project. * Feature/update sample env files (#2320) * Feature: update sample .env files * Remove old production .env file * Update DEVELOPMENT.md to reflect project state * Update CHANGELOG.md before PR * Link JIRA ticket # on relevant changes * Bring bugfixes from main into gdx-dev (#2328) * Made slug url case insensitive , Fixed bug with wrong query join for submission (#2321) * Made slug url case insensitive , Fixed bug with wrong query join for submission * removed a couple of if statements * CSV export made working for multipage wizard surveys (#2322) --------- Co-authored-by: saravanpa-aot <[email protected]> * bugfix/deseng421: Changed engagement links so that they open in the same window/tab as opposed to a new one. (#2329) * Bugfix/deseng413 (#2330) * bugfix/deseng413: Upgraded BC-Sans font to newest version. * bugfix/deseng413: Small update to changelog for clarification. * Feature/deseng415 (#2334) * feature/deseng415: Added recording of date with feedback submission and displaying the data on admin side. * feature/deseng415: Fixed feedback schema, removed yup import, fixed change log date. * bugfix/deseng429: Removed outdated service class. (#2337) * bugfix/deseng429: Removed outdated service class. * bugfix/deseng429: Changed version and changelog to match deployments to gdx-main. * feature/deseng439: Finished the Timeline Widget and linted. * feature/deseng439: Updated changelog before merge. * feature/deseng439: Made revisions as per Alex and added sorting to React components. --------- Co-authored-by: Nat² <[email protected]> Co-authored-by: saravanpa-aot <[email protected]>
Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-415
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).