Upgrade met-web to axios version 0.28.0 from 0.26.1 (#2451)

* Upgrade met-web to axios version 0.28.0 from 0.26.1
bcgov · Apr 8, 2024 · e527862 · e527862
1 parent 13729fb
commit e527862
Show file tree

Hide file tree

Showing 7 changed files with 35 additions and 20 deletions.
diff --git a/CHANGELOG.MD b/CHANGELOG.MD
@@ -3,6 +3,9 @@
 - **Bugfix**: Submission of rejected comments [🎟️ DESENG-527](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-527)
   - Fixed issue where resubmitted comments would not reappear in the queue for approval.
   - Added unit tests to ensure the issue does not reoccur.
+- **Task**: MET - Clean up outstanding dependabot PRs [DESENG-535](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-535)
+  - Bump axios from 0.26.1 to 0.28.0 in met-web. Dependabot suggested this upgrade, but it required a few minor code changes.
+  - Updated the type definition of the 'error' parameter to include a generic type '{ message?: string }' to handle the AxiosError response properly.
 
 ## April 05, 2024
 

diff --git a/met-web/package-lock.json b/met-web/package-lock.json
diff --git a/met-web/package.json b/met-web/package.json
@@ -32,7 +32,7 @@
         "@types/react-dom": "^18.0.2",
         "@types/react-draft-wysiwyg": "^1.13.4",
         "@types/react-redux": "^7.1.24",
-        "axios": "^0.26.1",
+        "axios": "^0.28.0",
         "date-fns": "^2.28.0",
         "date-fns-tz": "^1.3.4",
         "dayjs": "^1.11.6",

diff --git a/...b/src/components/engagement/form/EngagementFormTabs/UserManagement/AddTeamMemberModal.tsx b/...b/src/components/engagement/form/EngagementFormTabs/UserManagement/AddTeamMemberModal.tsx
@@ -84,11 +84,11 @@ export const AddTeamMemberModal = () => {
         }, 1000),
     ).current;
 
-    const setErrors = (error: AxiosError) => {
+    const setErrors = (error: AxiosError<{ message?: string }>) => {
         if (error.response?.status !== 409) {
             return;
         }
-        setBackendError(error.response?.data.message || '');
+        setBackendError(error.response?.data?.message || '');
     };
 
     const onSubmit: SubmitHandler<AddTeamMemberForm> = async (data: AddTeamMemberForm) => {

diff --git a/met-web/src/components/userManagement/listing/AddUserModal.tsx b/met-web/src/components/userManagement/listing/AddUserModal.tsx
@@ -106,11 +106,11 @@ export const AddUserModal = () => {
         );
     };
 
-    const setErrors = (error: AxiosError) => {
+    const setErrors = (error: AxiosError<{ message?: string }>) => {
         if (error.response?.status !== 409) {
             return;
         }
-        setBackendError(error.response?.data.message || '');
+        setBackendError(error.response?.data?.message || '');
     };
 
     const onSubmit: SubmitHandler<AddUserForm> = async (data: AddUserForm) => {

diff --git a/met-web/src/components/userManagement/listing/AssignRoleModal.tsx b/met-web/src/components/userManagement/listing/AssignRoleModal.tsx
@@ -86,11 +86,11 @@ export const AssignRoleModal = () => {
         setBackendError('');
     };
 
-    const setErrors = (error: AxiosError) => {
+    const setErrors = (error: AxiosError<{ message?: string }>) => {
         if (error.response?.status !== 409) {
             return;
         }
-        setBackendError(error.response?.data.message || '');
+        setBackendError(error.response?.data?.message || '');
     };
 
     const loadEngagements = async (searchText: string) => {

diff --git a/met-web/src/components/userManagement/userDetails/AddToEngagement.tsx b/met-web/src/components/userManagement/userDetails/AddToEngagement.tsx
@@ -157,11 +157,11 @@ export const AddToEngagementModal = () => {
         getUserMemberships();
     };
 
-    const setErrors = (error: AxiosError) => {
+    const setErrors = (error: AxiosError<{ message?: string }>) => {
         if (error.response?.status !== HTTP_STATUS_CODES.CONFLICT) {
             return;
         }
-        setBackendError(error.response?.data.message || '');
+        setBackendError(error.response?.data?.message || '');
     };
 
     const onSubmit: SubmitHandler<AddUserForm> = async (data: AddUserForm) => {