Skip to content

Commit

Permalink
Updating changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
VineetBala-AOT committed Jan 16, 2024
1 parent 31079e5 commit da4aeb8
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 27 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.MD
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
## January 15, 2024

- **Task** Audit for missing unit tests [🎟️DESENG-436](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-436)
- Corrected tests to execute smoothly in the local environment using development variables.
- Established continuous integration configuration to automatically run tests upon each commit.
- Ensured that the tests pass successfully in our GitHub test environment.
- **Task** Audit for missing unit tests [🎟️DESENG-449](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-449)
- Identified and corrected failing unit test for api and web

## January 10, 2024

- **Task** Custom Consent per Engagement [🎟️DESENG-456](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-456)
Expand Down
4 changes: 1 addition & 3 deletions met-web/src/components/engagement/form/ActionContext.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
getEngagementMetadata,
patchEngagementMetadata,
} from '../../../services/engagementMetadataService';
import { useLocation, useNavigate, useParams } from 'react-router-dom';
import { useNavigate, useParams } from 'react-router-dom';
import { EngagementContext, EngagementForm, EngagementFormUpdate, EngagementParams } from './types';
import {
createDefaultEngagement,
Expand Down Expand Up @@ -55,8 +55,6 @@ export const ActionContext = createContext<EngagementContext>({

export const ActionProvider = ({ children }: { children: JSX.Element }) => {
const { engagementId } = useParams<EngagementParams>();
const { search } = useLocation();
const searchParams = new URLSearchParams(search);
const navigate = useNavigate();
const dispatch = useAppDispatch();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export const EngagementTabsContext = createContext<EngagementTabsContextState>({
});

export const EngagementTabsContextProvider = ({ children }: { children: React.ReactNode }) => {
const { savedEngagement, engagementMetadata } = useContext(ActionContext);
const { savedEngagement } = useContext(ActionContext);
const dispatch = useAppDispatch();
const [engagementFormData, setEngagementFormData] = useState<EngagementFormData>({
name: savedEngagement.name || '',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ import {
FormGroup,
FormControlLabel,
Checkbox,
Select,
SelectChangeEvent,
MenuItem,
FormControl,
useMediaQuery,
Theme,
Expand All @@ -19,7 +16,6 @@ import { PrimaryButton, SecondaryButton } from '../../../common';
import dayjs from 'dayjs';
import { formatToUTC } from 'components/common/dateHelper';
import { SearchOptions } from './SearchTypes';
import { AppConfig } from 'config';

interface filterParams {
setFilterParams: (newsearchOptions: SearchOptions) => void;
Expand All @@ -38,13 +34,6 @@ const AdvancedSearch: React.FC<filterParams> = ({ setFilterParams }) => {
};
const [statusFilters, setStatusFilters] = useState(initialStatusFilters);

const initialFilterParams = {
status_list: [],
created_from_date: '',
created_to_date: '',
published_from_date: '',
published_to_date: '',
};
const handleStatusFilterChange = (event: React.SyntheticEvent) => {
setStatusFilters({
...statusFilters,
Expand Down
2 changes: 1 addition & 1 deletion met-web/src/components/engagement/view/EmailPanel.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { FormEvent, useContext, useState } from 'react';
import { ActionContext } from './ActionContext';
import { Grid, Checkbox, TextField, FormControl, FormControlLabel, FormHelperText, Stack, Link } from '@mui/material';
import { Grid, Checkbox, TextField, FormControl, FormControlLabel, FormHelperText, Stack } from '@mui/material';
import { EmailPanelProps } from './types';
import {
MetLabel,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,27 +1,23 @@
import React, { useState, useContext } from 'react';
import { MetDisclaimer } from 'components/common';
import { ActionContext } from '../../ActionContext';
import { Link, Typography, Box, useMediaQuery, Theme } from '@mui/material';
import { useAppDispatch, useAppSelector } from 'hooks';
import { useAppDispatch } from 'hooks';
import { openNotificationModal } from 'services/notificationModalService/notificationModalSlice';
import EmailModal from 'components/common/Modals/EmailModal';
import { createSubscribeEmailVerification } from 'services/emailVerificationService';
import { createSubscription } from 'services/subscriptionService';
import { EmailVerificationType } from 'models/emailVerification';
import { SubscriptionType } from 'constants/subscriptionType';
import { TenantState } from 'reduxSlices/tenantSlice';
import { Editor } from 'react-draft-wysiwyg';
import { getEditorStateFromRaw } from 'components/common/RichTextEditor/utils';

const EmailListModal = ({ open, setOpen }: { open: boolean; setOpen: (open: boolean) => void }) => {
const dispatch = useAppDispatch();
const isSmallScreen: boolean = useMediaQuery((theme: Theme) => theme.breakpoints.down('sm'));
const { savedEngagement, engagementMetadata } = useContext(ActionContext);
const { savedEngagement } = useContext(ActionContext);
const defaultType = SubscriptionType.ENGAGEMENT;
const [email, setEmail] = useState('');
const [isSaving, setIsSaving] = useState(false);
const [subscriptionType, setSubscriptionType] = useState<string>(defaultType);
const tenant: TenantState = useAppSelector((state) => state.tenant);

const sendEmail = async () => {
try {
Expand Down Expand Up @@ -95,10 +91,6 @@ const EmailListModal = ({ open, setOpen }: { open: boolean; setOpen: (open: bool
}
};

const handleSubscriptionChange = (type: string) => {
setSubscriptionType(type);
};

return (
<EmailModal
open={open}
Expand Down
1 change: 0 additions & 1 deletion met-web/src/components/landing/LandingComponent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { debounce } from 'lodash';
import { EngagementDisplayStatus } from 'constants/engagementStatus';
import { LandingContext } from './LandingContext';
import { Container } from '@mui/system';
import { AppConfig } from 'config';
import LandingPageBanner from 'assets/images/LandingPageBanner.png';
import { useAppTranslation } from 'hooks';

Expand Down

0 comments on commit da4aeb8

Please sign in to comment.