More lint errors fixed

bcgov · Mar 11, 2024 · 43127af · 43127af
1 parent 331a540
commit 43127af
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/...ents/engagement/form/EngagementFormTabs/AdditionalDetails/Metadata/EngagementMetadata.tsx b/...ents/engagement/form/EngagementFormTabs/AdditionalDetails/Metadata/EngagementMetadata.tsx
@@ -9,7 +9,7 @@ import { TaxonFormValues } from 'components/metadataManagement/types';
 import { useTheme } from '@mui/material/styles';
 import { ActionContext } from '../../../ActionContext';
 import * as yup from 'yup';
-import { defaultAutocomplete } from './TaxonInputComponents';
+import { DefaultAutocomplete } from './TaxonInputComponents';
 import { yupResolver } from '@hookform/resolvers/yup';
 import { bulkPatchEngagementMetadata } from 'services/engagementMetadataService';
 import { openNotification } from 'services/notificationService/notificationSlice';
@@ -110,11 +110,11 @@ const EngagementMetadata = forwardRef((_props, ref) => {
         },
     }));
 
-    const renderTaxonTile = (taxon: MetadataTaxon, index: number) => {
+    const TaxonTile = (taxon: MetadataTaxon, index: number) => {
         const taxonType = TaxonTypes[taxon.data_type as keyof typeof TaxonTypes];
         const theme = useTheme();
         const taxonValue = watch(taxon.id.toString());
-        const TaxonInput = taxonType.customInput ?? defaultAutocomplete;
+        const TaxonInput = taxonType.customInput ?? DefaultAutocomplete;
         return (
             <Grid
                 item
@@ -192,7 +192,7 @@ const EngagementMetadata = forwardRef((_props, ref) => {
                     spacing={3}
                     padding={2}
                 >
-                    {tenantTaxa.map(renderTaxonTile)}
+                    {tenantTaxa.map(TaxonTile)}
                 </Grid>
             </form>
         </Grid>

diff --git a/...ts/engagement/form/EngagementFormTabs/AdditionalDetails/Metadata/TaxonInputComponents.tsx b/...ts/engagement/form/EngagementFormTabs/AdditionalDetails/Metadata/TaxonInputComponents.tsx
@@ -14,7 +14,7 @@ import {
 } from '@mui/material';
 import { FieldError } from 'react-hook-form';
 
-export const defaultAutocomplete = ({ taxon, taxonType, field, setValue, errors, trigger }: TaxonInputProps) => {
+export const DefaultAutocomplete = ({ taxon, taxonType, field, setValue, errors, trigger }: TaxonInputProps) => {
     const [inputValue, setInputValue] = useState('');
 
     const valueErrors = (errors[taxon.id.toString()] as unknown as Array<FieldError> | FieldError) ?? [];
@@ -30,7 +30,7 @@ export const defaultAutocomplete = ({ taxon, taxonType, field, setValue, errors,
         errorMessage = (valueErrors as Array<FieldError>)?.map((error: FieldError, index: number) => {
             errorIndices.add(index);
             return (
-                <span>
+                <span key={index.toString() + error.message ?? ''}>
                     Entry #{index + 1}: {error.message}
                     <br />
                 </span>

diff --git a/met-web/src/components/metadataManagement/TaxonEditor.tsx b/met-web/src/components/metadataManagement/TaxonEditor.tsx
@@ -208,6 +208,7 @@ export const TaxonEditor = () => {
                                         orderedMetadataTaxa.map((taxon: MetadataTaxon, index) => {
                                             return (
                                                 <TaxonCard
+                                                    key={taxon.id}
                                                     taxon={taxon}
                                                     index={index}
                                                     onExpand={handleExpandTaxon}

diff --git a/met-web/src/components/metadataManagement/presetFieldsEditor/PresetValuesEditor.tsx b/met-web/src/components/metadataManagement/presetFieldsEditor/PresetValuesEditor.tsx
@@ -24,7 +24,7 @@ const PresetValuesEditor = ({
                 const errorMessage = valueErrors?.map((error: FieldError, index: number) => {
                     errorIndices.add(index);
                     return (
-                        <span key={index}>
+                        <span key={index.toString() + error.message ?? ''}>
                             Entry #{index + 1}: {error.message}
                             <br />
                         </span>
@@ -56,7 +56,7 @@ const PresetValuesEditor = ({
                                         variant="outlined"
                                         label={option}
                                         {...getTagProps({ index })}
-                                        key={index}
+                                        key={option}
                                         color={errorIndices.has(index) ? 'error' : 'default'}
                                     />
                                 ))}