Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.7 #2063

Merged
merged 30 commits into from
Feb 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
152a7f8
TCVP-3152: Added functionality to search by disputant surname or orga…
karahanb Jan 13, 2025
227da98
TCVP-3152: Added a note to sort_by parameter for search endpoint to i…
karahanb Jan 14, 2025
c62c26a
2.7.0 bumped the version
Jan 15, 2025
6bd72e4
Merge pull request #2045 from bcgov/feature/TCVP-3152-add-filtering-a…
karahanb Jan 16, 2025
b01a7a0
TCVP-3152 Added the org name fields
Jan 22, 2025
3f5b74d
TCVP-3173 IProvinceLookupService already caches the response data.
pbolduc Jan 22, 2025
4bcee07
Merge pull request #2050 from bcgov/bug/TCVP-3173
pbolduc Jan 22, 2025
f1651f9
Merge pull request #2049 from bcgov/feature/TCVP-3152-front-end
saikrishnametpalli-nttdata Jan 22, 2025
f615c45
2.7.1 bumped up the version
Jan 22, 2025
2a20e55
TCVP-3170 display statute short description
pbolduc Jan 22, 2025
c539faf
TCVP-3070 fixed the totalFineAmount access
Jan 22, 2025
49e968c
Merge pull request #2051 from bcgov/bug/TCVP-3170
pbolduc Jan 22, 2025
5a956b1
Merge pull request #2052 from bcgov/feature/TCVP-3070
saikrishnametpalli-nttdata Jan 22, 2025
d282afd
2.7.2 Bumped up the version
Jan 22, 2025
99317ad
TCVP-3070 fixed the display issue
Jan 23, 2025
b67ead4
TCVP-3128 changed the error messages
Jan 23, 2025
fa2d733
Merge pull request #2054 from bcgov/bug/TCVP-3128
saikrishnametpalli-nttdata Jan 23, 2025
27dcb35
Merge pull request #2053 from bcgov/feature/TCVP-3070
saikrishnametpalli-nttdata Jan 23, 2025
1309baf
2.7.3 Bumped up the version
Jan 23, 2025
4fc0e77
TCVP-3070 fixed TTP issue
Jan 24, 2025
a3cb00a
TCVP-3070 made date consistent
Jan 24, 2025
5b75f15
Merge pull request #2055 from bcgov/feature/TCVP-3070
saikrishnametpalli-nttdata Jan 24, 2025
565b699
2.7.4 Bumped up the version
Jan 24, 2025
b613434
TCVP-3070 fixed the findings issue
Jan 27, 2025
0612401
Merge pull request #2056 from bcgov/feature/TCVP-3070
saikrishnametpalli-nttdata Jan 27, 2025
c072561
2.7.5 Bumped up the version
Jan 27, 2025
7c154c8
TCVP-3070 Changed the logic based on time to pay and findings selection
Jan 27, 2025
ebef0f1
TCVP-3070 Added the condition for revised due date if exists
Jan 27, 2025
723d2a1
Merge pull request #2057 from bcgov/feature/TCVP-3070
saikrishnametpalli-nttdata Jan 27, 2025
15e9094
2.7.6 Bumped up the version
Jan 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions gitops/charts/traffic-court-dev-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ global:

arc-dispute-api:
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
env:
"Swagger__Enabled": "true"

citizen-api:
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
env:
"FormRecognizer__ApiVersion": "2022-08-31"
Expand All @@ -30,7 +30,7 @@ citizen-api:

citizen-web:
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
route:
# https://dev.justice.gov.bc.ca
Expand All @@ -39,7 +39,7 @@ citizen-web:
{
"production": false,
"environment": "Dev",
"version": "2.6.7",
"version": "2.7.6",
"useMockServices": false,
"apiBaseUrl": "/api",
"understandYourTicketLink": "https://understandmyticket.gov.bc.ca/",
Expand Down Expand Up @@ -193,7 +193,7 @@ citizen-web:

oracle-data-api:
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
env:
"JAVA_OPTS": "-Dlogging.level.ca.bc.gov.open.jag.tco.oracledataapi=DEBUG"
Expand All @@ -208,7 +208,7 @@ oracle-data-api:

staff-api:
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
env:
"Jwt__Audience": "staff-api"
Expand All @@ -222,7 +222,7 @@ staff-api:
"TicketSearch__SearchType": "RoadSafety"
staff-web:
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
route:
# https://dev.jag.gov.bc.ca
Expand All @@ -241,7 +241,7 @@ staff-web:
{
"production": false,
"environment": "Dev",
"version": "2.6.7",
"version": "2.7.6",
"useMockServices": false,
"apiBaseUrl": "/api",
"features": {
Expand All @@ -251,7 +251,7 @@ staff-web:

workflow-service:
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
env:
"EmailConfiguration__Sender": "[email protected]"
Expand Down
18 changes: 9 additions & 9 deletions gitops/charts/traffic-court-prod-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ arc-dispute-api:
pdb:
create: true
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
env:
"Swagger__Enabled": "false"
Expand All @@ -20,7 +20,7 @@ citizen-api:
pdb:
create: true
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
env:
"FormRecognizer__ApiVersion": "2022-08-31"
Expand All @@ -39,13 +39,13 @@ citizen-web:
pdb:
create: true
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
appConfig: |
{
"production": true,
"environment": "prod",
"version": "2.6.7",
"version": "2.7.6",
"useMockServices": false,
"apiBaseUrl": "/api",
"understandYourTicketLink": "https://understandmyticket.gov.bc.ca/",
Expand Down Expand Up @@ -221,7 +221,7 @@ oracle-data-api:
pdb:
create: true
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
env:
"JAVA_OPTS": ""
Expand All @@ -238,7 +238,7 @@ staff-api:
pdb:
create: true
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
env:
"Jwt__Audience": "staff-api"
Expand All @@ -263,7 +263,7 @@ staff-web:
pdb:
create: true
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
route:
# https://test.jag.gov.bc.ca
Expand All @@ -282,7 +282,7 @@ staff-web:
{
"production": true,
"environment": "prod",
"version": "2.6.7",
"version": "2.7.6",
"useMockServices": false,
"apiBaseUrl": "/api",
"features": {
Expand Down Expand Up @@ -407,7 +407,7 @@ workflow-service:
pdb:
create: true
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
env:
"EmailConfiguration__Sender": "[email protected]"
Expand Down
18 changes: 9 additions & 9 deletions gitops/charts/traffic-court-test-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ arc-dispute-api:
pdb:
create: true
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
env:
"Swagger__Enabled": "true"
Expand All @@ -20,7 +20,7 @@ citizen-api:
pdb:
create: true
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
env:
"FormRecognizer__ApiVersion": "2022-08-31"
Expand All @@ -39,7 +39,7 @@ citizen-web:
pdb:
create: true
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
route:
# https://test.justice.gov.bc.ca
Expand All @@ -48,7 +48,7 @@ citizen-web:
{
"production": false,
"environment": "Test",
"version": "2.6.7",
"version": "2.7.6",
"useMockServices": false,
"apiBaseUrl": "/api",
"understandYourTicketLink": "https://bcmoag--staging.sandbox.my.salesforce-sites.com/?tn=BCTC",
Expand Down Expand Up @@ -205,7 +205,7 @@ oracle-data-api:
pdb:
create: true
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
env:
"JAVA_OPTS": ""
Expand All @@ -222,7 +222,7 @@ staff-api:
pdb:
create: true
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
env:
"Jwt__Audience": "staff-api"
Expand All @@ -240,7 +240,7 @@ staff-web:
pdb:
create: true
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
route:
# https://test.jag.gov.bc.ca
Expand All @@ -259,7 +259,7 @@ staff-web:
{
"production": false,
"environment": "Test",
"version": "2.6.7",
"version": "2.7.6",
"useMockServices": false,
"apiBaseUrl": "/api",
"features": {
Expand Down Expand Up @@ -322,7 +322,7 @@ workflow-service:
pdb:
create: true
image:
tag: "2.6.7"
tag: "2.7.6"
pullPolicy: Always
env:
"EmailConfiguration__Sender": "[email protected]"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ public async Task<IActionResult> GetJJDisputesAsync(string? jjAssignedTo, Cancel
/// <param name="submitted_thru">Disputes sumbitted on or before this date</param>
/// <param name="ticket_number"></param>
/// <param name="surname">The case insenstive surname to search for.</param>
/// <param name="surname_or_org_name">The case insenstive disputant surname or organization name to search for.</param>
/// <param name="jj_assigned_to">The JJ assigned user</param>
/// <param name="jj_decision_dt_from">The jj decision date where greater or equal to this date. Format must be YYYY-MM-DD.</param>
/// <param name="jj_decision_dt_thru">The jj decision date where less or equal to this date. Format must be YYYY-MM-DD.</param>
Expand All @@ -104,7 +105,7 @@ public async Task<IActionResult> GetJJDisputesAsync(string? jjAssignedTo, Cancel
/// <param name="hearing_type_cd">The hearing type code to search.</param>
/// <param name="page_number">The page number to fetch. Starts at 1.</param>
/// <param name="page_size">The page size to use. If not specified, defaults to 25</param>
/// <param name="sort_by">The list of columns to sort the result by. To sort descending, add a '-' before the column name.</param>
/// <param name="sort_by">The list of columns to sort the result by. To sort descending, add a '-' before the column name. Note: 'surnameOrOrgName' is a pseudo field for sorting by surname or organization name.</param>
/// <param name="cancellationToken"></param>
/// <returns></returns>
#if DEBUG
Expand All @@ -126,6 +127,7 @@ public async Task<IActionResult> SearchDisputesAsync(
string? submitted_thru,
string? ticket_number,
string? surname,
string? surname_or_org_name,
string? jj_assigned_to,
string? jj_decision_dt_from,
string? jj_decision_dt_thru,
Expand All @@ -151,6 +153,7 @@ public async Task<IActionResult> SearchDisputesAsync(
submitted_thru = submitted_thru,
ticket_number = ticket_number,
surname = surname,
surname_or_org_name = surname_or_org_name,
jj_assigned_to = jj_assigned_to,
jj_decision_dt_from = jj_decision_dt_from,
jj_decision_dt_thru = jj_decision_dt_thru,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,12 @@ private void AddWhere(Dictionary<string, string> parameters, Request request)
AddUtcDateRangeFilter(parameters, "jj_decision_dt", request.time_zone, request.jj_decision_dt_from, request.jj_decision_dt_thru);

AddDateRangeFilter(parameters, "appr_tm", request.appearance_dt_from, request.appearance_dt_thru);

// Search where starts with the spuplied value. We could also use "_regexp_like" and use a regex pattern
// Search where starts with the supplied value. We could also use "_regexp_like" and use a regex pattern
// ticket number is always uppercase
AddLikeFilter(parameters, "ticket_number_txt", request.ticket_number);
AddLikeFilter(parameters, "prof_surname_nm", request.surname);
AddLikeFilter(parameters, "prof_surname_nm_or_org_nm", request.surname_or_org_name);

if (request.jj_assigned_to is not null) parameters.Add("jj_assigned_to_eq", request.jj_assigned_to);

Expand Down Expand Up @@ -266,6 +267,7 @@ void Append(string direction, string target)
"violationDate" => "violation_dt",
"toBeHeardAtCourthouseName" => "to_be_heard_at_agen_nm",
"surname" => "prof_surname_nm",
"surnameOrOrgName" => "prof_surname_nm_or_org_nm",
"disputantGivenName1" => "prof_given_1_nm",
"status" => "dispute_status_type_dsc",
"policeDetachment" => "detachment_agency_nm",
Expand Down Expand Up @@ -392,6 +394,7 @@ private DisputeCaseFileSummary Map(OrdsDisputeCaseFileSummary dispute)
DisputantGivenName1 = dispute.prof_given_1_nm,
DisputantGivenName2 = dispute.prof_given_2_nm,
DisputantGivenName3 = dispute.prof_given_3_nm,
DisputantOrganizationName = dispute.prof_org_nm,
FineReductionReason = dispute.fine_reduction_reason_txt,
TimeToPayReason = dispute.time_to_pay_reason_txt,
DisputeStatus = new DisputeCaseFileStatus
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ public class Request : IRequest<Response>

public string? ticket_number { get; set; }
public string? surname { get; set; }
public string? surname_or_org_name { get; set; }

public string? jj_assigned_to { get; set; }

Expand Down
Original file line number Diff line number Diff line change
@@ -1,47 +1,21 @@
using MediatR;
using TrafficCourts.OrdsDataService.Justin;
using ZiggyCreatures.Caching.Fusion;
using TrafficCourts.Staff.Service.Services;

namespace TrafficCourts.Staff.Service.Features.Lookups.Provinces;

public class Handler : IRequestHandler<Request, Response>
{
private readonly IProvinceRepository _repository;
private readonly IFusionCache _cache;
private readonly ILogger<Handler> _handler;
private readonly IProvinceLookupService _lookupService;

public Handler(IProvinceRepository repository, IFusionCache cache, ILogger<Handler> handler)
public Handler(IProvinceLookupService lookupService)
{
_repository = repository ?? throw new ArgumentNullException(nameof(repository));
_cache = cache ?? throw new ArgumentNullException(nameof(cache));
_handler = handler ?? throw new ArgumentNullException(nameof(handler));
_lookupService = lookupService ?? throw new ArgumentNullException(nameof(lookupService));
}

public async Task<Response> Handle(Request request, CancellationToken cancellationToken)
{
var key = Caching.Cache.Api.Provinces(2);

var items = await _cache.GetOrSetAsync<List<Domain.Models.Province>>(
key,
ct => GetItems(ct),
options => options.SetDuration(TimeSpan.FromMinutes(10)),
token: cancellationToken);
var items = await _lookupService.GetListAsync(cancellationToken);

return new Response(items);
}

private async Task<List<Domain.Models.Province>> GetItems(CancellationToken cancellationToken)
{
var items = await _repository.GetListAsync(cancellationToken);

var models = items.Select(_ => new Domain.Models.Province
(
_.ctry_id.ToString(),
_.prov_seq_no.ToString(),
_.prov_nm,
_.prov_abbreviation_cd
)).ToList();

return models;
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,22 @@
public long Id { get; set; }
public DateTimeOffset? SubmittedTs { get; set; }
public System.DateTimeOffset? JjDecisionDate { get; set; }
public string SignatoryName { get; set; }

Check warning on line 12 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / Create, format and upload .NET Backend coverage artifact

Non-nullable property 'SignatoryName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 12 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'SignatoryName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
public string? HearingType { get; set; }
public string TicketNumber { get; set; }

Check warning on line 14 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / Create, format and upload .NET Backend coverage artifact

Non-nullable property 'TicketNumber' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 14 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'TicketNumber' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
public DateTimeOffset? ViolationDate { get; set; }
public int ViolationDateCount { get; set; }
public decimal? ToBeHeardAtCourthouseId { get; set; }
public string ToBeHeardAtCourthouseName { get; set; }

Check warning on line 18 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / Create, format and upload .NET Backend coverage artifact

Non-nullable property 'ToBeHeardAtCourthouseName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 18 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'ToBeHeardAtCourthouseName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
public string DisputantSurname { get; set; }

Check warning on line 19 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / Create, format and upload .NET Backend coverage artifact

Non-nullable property 'DisputantSurname' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 19 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'DisputantSurname' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
public string DisputantGivenName1 { get; set; }

Check warning on line 20 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / Create, format and upload .NET Backend coverage artifact

Non-nullable property 'DisputantGivenName1' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 20 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'DisputantGivenName1' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
public string DisputantGivenName2 { get; set; }

Check warning on line 21 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / Create, format and upload .NET Backend coverage artifact

Non-nullable property 'DisputantGivenName2' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 21 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'DisputantGivenName2' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
public string DisputantGivenName3 { get; set; }

Check warning on line 22 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / Create, format and upload .NET Backend coverage artifact

Non-nullable property 'DisputantGivenName3' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 22 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'DisputantGivenName3' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
public string DisputantOrganizationName { get; set; }

Check warning on line 23 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / Create, format and upload .NET Backend coverage artifact

Non-nullable property 'DisputantOrganizationName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 23 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'DisputantOrganizationName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

public DisputeCaseFileStatus DisputeStatus { get; set; }

Check warning on line 25 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'DisputeStatus' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

public string PoliceDetachment { get; set; }

Check warning on line 27 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'PoliceDetachment' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
public decimal? PoliceDetachmentId { get; set; }
public YesNo? AccidentYn { get; set; }
public YesNo? MultipleOfficersYn { get; set; }
Expand Down Expand Up @@ -51,6 +52,6 @@

public class DisputeCaseFileStatus
{
public string Code { get; set; }

Check warning on line 55 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / Create, format and upload .NET Backend coverage artifact

Non-nullable property 'Code' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
public string Description { get; set; }

Check warning on line 56 in src/backend/TrafficCourts/TrafficCourts.Core/Domain/Models/DisputeCaseFileSummary.cs

View workflow job for this annotation

GitHub Actions / Create, format and upload .NET Backend coverage artifact

Non-nullable property 'Description' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ public class OrdsDisputeCaseFileSummary
public string prof_given_1_nm { get; set; }
public string prof_given_2_nm { get; set; }
public string prof_given_3_nm { get; set; }
public string prof_org_nm { get; set; }
public string time_to_pay_reason_txt { get; set; }
public string fine_reduction_reason_txt { get; set; }
public string dispute_status_type_cd { get; set; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ export class ViolationTicketService {
}

private openErrorScenarioFourDialog() {
return this.openImageTicketNotFoundDialog("Non-MVA ticket", "error2");
return this.openImageTicketNotFoundDialog("Invalid ticket type", "error8");
}

private openErrorScenarioSevenDialog() {
Expand All @@ -462,7 +462,7 @@ export class ViolationTicketService {
}

private openInValidETicketDateDialog() {
return this.openImageTicketNotFoundDialog(`Your ticket is past the allowable dispute time period`, "error5");
return this.openImageTicketNotFoundDialog(`Your ticket is over 30 days old`, "error5");
}

private openInValidISCTicketDateDialog() {
Expand Down
Loading
Loading