Merge pull request #1958 from bcgov/hotfix/TCVP-3049

TCVP-3049 ensure ICBC is called for print DCF
bcgov · Sep 10, 2024 · 95da347 · 95da347
2 parents d33d83e + df4edd2
commit 95da347
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/backend/TrafficCourts/Staff.Service/Services/DisputeService.cs b/src/backend/TrafficCourts/Staff.Service/Services/DisputeService.cs
@@ -130,9 +130,13 @@ public async Task<Dispute> GetDisputeAsync(GetDisputeOptions options, Cancellati
     {
         Dispute dispute = await _oracleDataApi.GetDisputeAsync(options.DisputeId, options.Assign, cancellationToken);
 
-        await GetOcrImageAndResults(dispute, cancellationToken);
-        await GetFileAttachments(dispute, cancellationToken);
-        await GetIcbcTicketInformation(dispute, options, cancellationToken);
+        // this should be safe since are updating different parts of the dispute in each of these calls
+        var ocrTask = GetOcrImageAndResults(dispute, cancellationToken);
+        var fileTask = GetFileAttachments(dispute, cancellationToken);
+        var icbcTask = GetIcbcTicketInformation(dispute, options, cancellationToken);
+
+        // wait for them all to complete
+        await Task.WhenAll(ocrTask, fileTask, icbcTask);
 
         return dispute;
     }

diff --git a/src/backend/TrafficCourts/Staff.Service/Services/PrintDigitalCaseFileService.cs b/src/backend/TrafficCourts/Staff.Service/Services/PrintDigitalCaseFileService.cs
@@ -77,7 +77,7 @@ public async Task<RenderedReport> PrintTicketValidationViewAsync(long disputeId,
     /// <returns></returns>
     internal async Task<DigitalCaseFile> GetDigitalCaseFileAsync(long disputeId, TimeZoneInfo timeZone, CancellationToken cancellationToken)
     {
-        GetDisputeOptions options = new GetDisputeOptions {  DisputeId = disputeId, Assign = false };
+        GetDisputeOptions options = new GetDisputeOptions {  DisputeId = disputeId, Assign = false, GetNameFromIcbc = true };
 
         var dispute = await _disputeService.GetDisputeAsync(options, cancellationToken);