HOSTSD-209 Fix all servers and auth bugs #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
commented
Jan 19, 2024
| const state = useAuth(); | ||
|
|
||
| // Only allow Organization Admin role to view this page. | ||
| if (state.status === 'loading') return <div>Loading...</div>; |
There was a problem hiding this comment.
I was hoping to extract this logic and put it into a shared function, but I can't seem to figure out the best way to do this because it's a conditional render.
| available: fsi.availableSpace, | ||
| data: fsi, | ||
| })) | ||
| .sort((a, b) => |
| if (selectedServerItem) setDashboardServerItems([selectedServerItem]); | ||
| else setDashboardServerItems(filteredServerItems); | ||
|
|
||
| setDashboardDateRange(filteredDateRange); | ||
|
|
||
| if (filteredServerItem) | ||
| if (selectedServerItem) |
There was a problem hiding this comment.
Correctly loads the currently selected server now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've rewritten the page authorization so that we can now refresh the page and it won't redirect until it's completed loading the token.
Drive space will now load correct when a server is selected on the dashboard.
All servers will load correctly when you view that page before going to the dashboard.