HOSTSD-227 HSB user pages #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
commented
Jan 17, 2024
| export default function Page() { | ||
| useSecureRoute((state) => state.isOrganizationAdmin, '/'); |
There was a problem hiding this comment.
Simple way to force redirect. What I don't like about it is that the whole page needs to be use client for it to work.
| ); | ||
| useSecureRoute((state) => state.isClient, '/'); | ||
|
|
||
| return <Dashboard />; |
There was a problem hiding this comment.
Moved all this common logic to a single component that both HSB and Client users can share.
| return ( | ||
| <Col> | ||
| <h1></h1>All Servers | ||
| <AllocationByStorageVolume organizations={organizations} serverItems={serverItems} /> |
There was a problem hiding this comment.
The all servers page chart doesn't expand correctly.
| import { useAllocationByOS } from './hooks'; | ||
| import { getColumns, getLabel } from './utils'; | ||
|
|
||
| export interface IAllocationTableProps { | ||
| /** Filter servers by their OS */ | ||
| operatingSystem: OperatingSystems; | ||
| operatingSystem?: string; |
There was a problem hiding this comment.
I've moved the data out so that it can be passed in by the parent.
|
|
||
| /** | ||
| * Provides a function to filter server items. | ||
| * @param operatingSystem Operating system filter. | ||
| * @returns Function to filter server items by operating system and predicate. | ||
| */ | ||
| export const useAllocationByOS = (operatingSystem: OperatingSystems) => { | ||
| export const useAllocationByOS = (operatingSystem?: string) => { |
There was a problem hiding this comment.
Improved implementation to not require an enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All pages for HSB users have been wired up with basic functionality. There are some UI issues, but all these can be addressed later.
Drive Space Chart
Multi Organization
Single Organization
Single OS
Single Server
All Servers