HOSTSD-203 Add storage trends by drive #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
force-pushed
the
203
branch
2 times, most recently
from
89b7205 to
0e7f57f
Compare
Fosol
commented
Jan 12, 2024
| @@ -147,8 +147,7 @@ public IActionResult FindHistory() | |||
| var user = _authorization.GetUser(); | |||
| if (user == null) return Forbid(); | |||
|
|
|||
| var result = _fileSystemHistoryItemService.FindHistoryByMonth(filter.StartDate ?? DateTime.UtcNow.AddYears(-1), filter.EndDate, filter.TenantId, filter.OrganizationId, filter.OperatingSystemItemId, filter.ServerItemServiceNowKey); | |||
| // var result = _fileSystemHistoryItemService.FindForUser(user.Id, filter); | |||
| var result = _fileSystemHistoryItemService.FindHistoryByMonthForUser(user.Id, filter.StartDate ?? DateTime.UtcNow.AddYears(-1), filter.EndDate, filter.TenantId, filter.OrganizationId, filter.OperatingSystemItemId, filter.ServerItemServiceNowKey); | |||
| @@ -17,6 +18,7 @@ export default function Page() { | |||
| <TotalStorage /> | |||
| <AllocationByOS /> | |||
| <AllocationTable operatingSystem={OperatingSystems.Windows} /> | |||
| <SegmentedBarChart /> | |||
There was a problem hiding this comment.
Mostly formatting changes from my auto-linter
| justify-content: space-evenly; | ||
| } | ||
|
|
||
| .legend { |
There was a problem hiding this comment.
Added this to display the label on two lines.
| 'November', | ||
| 'December', | ||
| ]; | ||
| export const SegmentedBarChart = ({ maxVolumes = 4 }: ISegmentedBarChart) => { |
There was a problem hiding this comment.
When a user selected the server in the filter it will automatically display the drives in this chart.
| .slice(0, actualMaxVolumes) | ||
| .map((volume, index) => { | ||
| // Get color pair based on the current drive | ||
| const cIndex = |
There was a problem hiding this comment.
This handles more than 3 volumes and keeps reusing the 3 colours.
| @@ -0,0 +1,5 @@ | |||
| export const extractVolumeName = (name?: string) => { | |||
There was a problem hiding this comment.
Need this to keep the linux names shorter in the label
| * @param minColumns Minimum number of columns | ||
| * @returns An array of months to contain history for each month. | ||
| */ | ||
| export const useStorageHistoryDateRange = <T>(minColumns: number = 1) => { |
There was a problem hiding this comment.
Extracted to separate hook so it can be shared.
| @@ -18,18 +20,18 @@ export const useDashboardFileSystemHistoryItems = () => { | |||
| const fetch = React.useCallback( | |||
| async (filter: IFileSystemHistoryItemFilter) => { | |||
| try { | |||
| setServerHistoryItemsReady(false); | |||
| setFileSystemHistoryItemsReady(false); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was complicated. Many of our servers have more than 3 mapped volumes, and many have no mapped volumes. I have updated the Storage Trends by Drive to display how many total drives are on the server.
There are many drives with 0 storage, which could be a data issue, or simple some of these drives are not relevant (i.e. System).
Linux
I've extracted the last portion of their mapped name for the label.
Windows