Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTSD-177 - Adding Server Allocation Table #44

Merged
merged 4 commits into from
Jan 8, 2024
Merged

HOSTSD-177 - Adding Server Allocation Table #44

merged 4 commits into from
Jan 8, 2024

Conversation

wkaspryk
Copy link
Collaborator

@wkaspryk wkaspryk commented Jan 8, 2024

Adding new component for Server Allocation table
This table component can be reused on the 'All Servers' page, when 'Tenant' is added to the data, a new column will appear in the table.
In the current implementation, all rows of data must have a 'tenant' or any row without it will be misaligned.

@wkaspryk wkaspryk requested a review from Fosol January 8, 2024 22:22
@Fosol Fosol assigned Fosol and wkaspryk and unassigned Fosol Jan 8, 2024
@Fosol Fosol added the enhancement New feature or request label Jan 8, 2024
Copy link
Contributor

@Fosol Fosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the className package provide?

@wkaspryk
Copy link
Collaborator Author

wkaspryk commented Jan 8, 2024

What does the className package provide?

It provides a way to conditionally display a class and join it to an element without having to manually concatenate it. An example is line 45 on 'AllocationTable.tsx'. Seems slightly cleaner, not a huge difference though

@Fosol Fosol added this pull request to the merge queue Jan 8, 2024
Merged via the queue into main with commit 90732d8 Jan 8, 2024
1 check passed
@Fosol Fosol deleted the 177 branch January 8, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants