HOSTSD-199 Add storage trends chart #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
commented
Jan 4, 2024
| padding-left: 42px; | ||
| } | ||
|
|
||
| .spinner { |
| import React from 'react'; | ||
| import { IStats } from './IStats'; | ||
| import { defaultData } from './defaultData'; | ||
| import { updateData } from './updateData'; | ||
|
|
||
| export const useDonutChart = () => { | ||
| const serverItem = useFiltered((state) => state.serverItem); | ||
| const serverItems = useFiltered((state) => state.serverItems); | ||
| const serverItems = useDashboard((state) => state.serverItems); |
| const { organizations } = useOrganizations(); | ||
| const { operatingSystemItems } = useOperatingSystemItems(); | ||
| const { serverItems } = useServerItems(); | ||
| const { isReady: tenantsReady, tenants } = useTenants(); |
There was a problem hiding this comment.
Filter now displays loading spinners
| @@ -111,4 +111,20 @@ | |||
| .selected { | |||
| background-color: $bc-blue; | |||
| color: $white; | |||
| } | |||
|
|
|||
| .spinner { | |||
| * @returns A string representing the storage size. | ||
| */ | ||
| export const convertToStorageSize = ( | ||
| export const convertToStorageSize = <T extends string | number>( |
There was a problem hiding this comment.
Needed a way to return just the converted value. I don't love the generics in this case.
| @@ -291,10 +291,6 @@ private async Task ProcessConfigurationItemsAsync(Models.DataSyncModel option) | |||
| _serverItems[serverItem.ServiceNowKey] = serverItem; | |||
| } | |||
|
|
|||
| // Add the server history item to HSB. | |||
There was a problem hiding this comment.
Adding historical records is the api job now
| @@ -15,6 +15,7 @@ public override void Configure(EntityTypeBuilder<ServerItem> builder) | |||
| builder.Property(m => m.TenantId); | |||
| builder.Property(m => m.OrganizationId); | |||
| builder.Property(m => m.OperatingSystemItemId); | |||
| builder.Property(m => m.HistoryKey); | |||
There was a problem hiding this comment.
This is essentially a foreign key, but it's not enforced otherwise we'd have a chicken/egg issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have storage trends and a way to access historical data.
I needed to update the DB schema to support maintaining a link between historical server items and the current server item. This was required to improve performance by offloading capacity calculations to the Data Server.
I've also added some horrible looking loading spinners to slightly improve the user experience when waiting for data.
Loading Spinners
Dashboard