Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVXT-1781: Upgrade backstage backend #189

Merged
merged 13 commits into from
Nov 12, 2024
Merged

DEVXT-1781: Upgrade backstage backend #189

merged 13 commits into from
Nov 12, 2024

Conversation

MonicaG
Copy link
Contributor

@MonicaG MonicaG commented Oct 28, 2024

  • update to version 1.32.4
  • updated to use new backend system

Major changes:

  • Removed all of the packages/backend/src/plugins files
    • The catalog and stackoverflow configuration that were done in the catalog.ts and search.ts files were moved into the app-config.production.yaml file
    • Permission code was moved into new packages/backend/src/extensions/permissionsPolicyExtension.ts file
    • I also tried to clean up the spread of configuration. The stackoverflow and auth configs are now part or app-config.production.yaml file instead of having to be defined in every values.*.yaml file in the gitops repo.
  • Added the ProxiedSignInPage to the packages/app/src/App.tsx file.
    • This will allow us to use the site as before
    • updated the auth configuration in app-config.production.yaml to allow this process
  • Removed the LEGACY_BACKEND_START from the Dockerfile as we are now using the new backend
    • Also updated the Dockerfile to not pin the image tag. This will let us get security updates if available on a new build and is Docker's recommendation

Notes:

  • There is some whitespace formatting changes with the checkin because of our husky processor. These formatting changes will start to settle down as we update files.
  • Backstage has updated to yarn 4. I have created a separate ticket for that, as this PR is large enough.

@MonicaG MonicaG added the build Run workflow to build the code in this PR label Oct 28, 2024
Copy link
Contributor

@sheaphillips sheaphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a look at this now...

Copy link
Contributor

@sheaphillips sheaphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked through the changes and also brought this up locally. I don't have any concerns, other than maybe capturing a sample app config sometwhere for us to use internally, and maybe updating the README?

Copy link
Contributor

@oomIRL oomIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MonicaG
Copy link
Contributor Author

MonicaG commented Nov 12, 2024

I've looked through the changes and also brought this up locally. I don't have any concerns, other than maybe capturing a sample app config sometwhere for us to use internally, and maybe updating the README?

I've updated the README file and provided an app-config.local.template.yaml file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Run workflow to build the code in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants