-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVXT-1781: Upgrade backstage backend #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a look at this now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked through the changes and also brought this up locally. I don't have any concerns, other than maybe capturing a sample app config sometwhere for us to use internally, and maybe updating the README?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I've updated the README file and provided an |
Major changes:
packages/backend/src/plugins
filesapp-config.production.yaml
filepackages/backend/src/extensions/permissionsPolicyExtension.ts
fileapp-config.production.yaml
file instead of having to be defined in everyvalues.*.yaml
file in the gitops repo.ProxiedSignInPage
to thepackages/app/src/App.tsx
file.app-config.production.yaml
to allow this processLEGACY_BACKEND_START
from the Dockerfile as we are now using the new backendNotes: