Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test design tokens build #454

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Test design tokens build #454

merged 3 commits into from
Aug 19, 2024

Conversation

ty2k
Copy link
Contributor

@ty2k ty2k commented Aug 19, 2024

This PR adds a test script that uses the Node.js test runner to run the build script from build-output.js. For now, this only tests that the script completes without errors - it doesn't make any assertions about the different contents of the build directory. The new test script is added to the design tokens package.json file, and a GitHub Actions workflow is added that runs the test script when a PR updates files within the ./packages/design-tokens directory.

The goal of this is to allow us to more safely update the design tokens package and to give us a test framework that we can add new assertions to over time (correctness of select tokens, presence of the expected output formats, etc).

@ty2k ty2k requested a review from mkernohanbc August 19, 2024 18:34
@ty2k ty2k self-assigned this Aug 19, 2024
@ty2k ty2k added enhancement New feature or request dependencies Pull requests that update a dependency file labels Aug 19, 2024
@ty2k ty2k added this to the Design tokens v3.1.0 milestone Aug 19, 2024
@ty2k ty2k marked this pull request as ready for review August 19, 2024 18:36
Copy link
Contributor

@mkernohanbc mkernohanbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ty2k ty2k merged commit f830789 into main Aug 19, 2024
3 checks passed
@ty2k ty2k deleted the feature/test-design-tokens-build branch August 19, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants