Add Form component #401
Closed
Add Form component #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mkernohanbc
force-pushed
the
398-form-wrapper
branch
from
2836e7d to
b35e778
Compare
Merged
|
Did a rebase, thought better of it. Cherry-picked work from this branch into #409 instead. Closing this draft PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving this POC from #398 into a draft PR for discussion.
This PR adds a new Form component, based on RAC Form. An example instance and documentation page in Storybook is also included.
The Form component is intended to be used as a wrapper around other components, to provide additional support for data validation and submission and form styling. It renders an HTML
<form>element.By default, the Form component renders without any styling of its own. The
classNameprop can be used to style the form as a whole.Some boilerplate CSS is included (see Form.css). This is currently only used to style the example form in Storybook.