-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TextArea component #400
Conversation
@ty2k documenting our conversation for reference:
![]()
|
Flagging that the change in c9c44b5 is throwing a TS error in the console, but doesn't actually seem to affect how the component renders in Storybook:
Needs further investigation. |
This is fixed in a88ddc3. The Typescript error seemed to originate with the way we were implementing the warning icon within the
|
I've done some structural cleanup on this component over the past few days:
Only outstanding piece of work before this PR is ready for review is implementing the state handling for the character counter (awaiting @ty2k's input.) |
Co-Authored-By: Tyler Krys <[email protected]>
6227489
to
b510c5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rocks @mkernohanbc . Let me know if you want to pair on the SVG icon issue. No need to replace the other instances of that icon in this PR (in Select
and TextField
), but let's add the common version here to start.
This reverts commit 187086f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! We just need to clean up the SVG id
stuff and this can be merged. 👍 👍
packages/react-components/src/components/SvgExclamationIcon/SvgExclamationIcon.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/components/SvgExclamationIcon/SvgExclamationIcon.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
This PR expands on #389 to add a new Text Area component.
Text Area is an alternative implementation of Text Field, designed for multi-line plain text input.
Changes from Text Field:
Leaving this in draft for now, pending input from Philip on whether there should be any other design or behavioural variances between this and the base Text Field component.