Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expanded introduction page for Storybook #369

Merged

Conversation

mkernohanbc
Copy link
Contributor

This PR fleshes out Introduction.mdx to add more explanatory content and provide additional links to related resources and assets.

@ty2k looking for a steer on whether you think this is useful info/context, or if it's going too far into the weeds.

@mkernohanbc mkernohanbc added the content Issue related to content and writing label May 30, 2024
@mkernohanbc mkernohanbc self-assigned this May 30, 2024
@mkernohanbc mkernohanbc linked an issue May 30, 2024 that may be closed by this pull request
3 tasks
@mkernohanbc mkernohanbc requested a review from ty2k May 30, 2024 19:58
@mkernohanbc
Copy link
Contributor Author

mkernohanbc commented May 30, 2024

Bit of scope-creep on this PR:

30368d2 adds a new Changelog.mdx file which imports the main CHANGELOG.md file for the package into Storybook.

Copy link
Contributor

@ty2k ty2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most excellent 👌 The pattern of building the Changelog right into the Storybook instance is super helpful, I think.

Storybook introduction screen Storybook changelog screen

@mkernohanbc
Copy link
Contributor Author

mkernohanbc commented May 30, 2024

i have been dangerously encouraged, my next PR may well be trying to import all of our docs content from gov in iframes into storybook*

*this is probably a joke...

@mkernohanbc mkernohanbc merged commit 983556b into main May 30, 2024
1 check passed
@mkernohanbc mkernohanbc deleted the 304-update-storybook-front-matter-and-supporting-content branch May 31, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issue related to content and writing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Storybook front matter and supporting content
2 participants