Add missing typography-color-secondary to Select label #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philip-Cheung
approved these changes
May 28, 2024
mkernohanbc
reviewed
May 28, 2024
There was a problem hiding this comment.
My interpretation is that the main label should use --typography-color-primary, and the "(optional)" label should use --typography-color-secondary, but I think that @Philip-Cheung has the decision on what's correct here — adding him as a reviewer.
(Philip, this relates to the Figma change requested in https://github.com/orgs/bcgov/projects/106/views/3?pane=issue&itemId=63792131)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #354 , this adds a missing
colorto the Select component's label. Without this PR, the browser default black is being applied to the label:After this PR:
This makes the "main" label have the same color as the "(optional)" tag when it is present. Note that we are currently missing a canonical example of what this label should actually look like with the "(optional)" tag in our pre-release Figma component file: