Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions workflow for testing React components #360

Merged
merged 3 commits into from
May 28, 2024

Conversation

ty2k
Copy link
Contributor

@ty2k ty2k commented May 28, 2024

This adds a GitHub Actions workflow YAML file for running the Jest test suite added in #359.

This new workflow is set to run on any pull request that changes files within packages/react-components, regardless of the branch being targeted by the PR. This is to allow us the freedom to have longer-running feature branches for particular components that we repeatedly do PRs against before merging the entire feature branch back into main. Ex: A pull request from feature/card-vertical-image-handling into a longer-running feature/card branch.

For now, I've left out any step that uploads the Jest log anywhere. Some workflows do this using actions/upload-artifact, but I think we can probably get by without it by using the temporary logs in the workflow run.

In 60cda50 I'm attempting to use the version of Node.js specified in our .nvmrc file rather than hard-coding it. I've confirmed that nvm use still works for me locally without the v in the version number.

@ty2k ty2k requested a review from mkernohanbc May 28, 2024 22:12
@ty2k ty2k self-assigned this May 28, 2024
@ty2k ty2k merged commit a8d6337 into main May 28, 2024
1 check failed
@ty2k ty2k deleted the feature/github-action-workflow-test-react-components branch May 28, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants