Skip to content

Commit

Permalink
Merge pull request #358 from bcgov/bugfix/github-sha-environment-vari…
Browse files Browse the repository at this point in the history
…able-in-github-action

Use github.sha instead of pull request reference in GitHub Action for building React apps
  • Loading branch information
Sam-McGrew authored May 27, 2024
2 parents 22d2d49 + 4c3f922 commit df5d78b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build_react_component_library_apps.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
driver-opts: network=host

- name: Build image with docker build
run: docker build ./packages/react-components/ -f ./packages/react-components/Dockerfile.storybook -t design-system-react-components-storybook:latest --build-arg GITHUB_SHA=${{ github.event.pull_request.head.sha }}
run: docker build ./packages/react-components/ -f ./packages/react-components/Dockerfile.storybook -t design-system-react-components-storybook:latest --build-arg GITHUB_SHA=${{ github.sha }}

- name: Login to OpenShift Silver image registry
uses: docker/login-action@v3
Expand Down

0 comments on commit df5d78b

Please sign in to comment.